ui: Make InProcess context on-screen if it has a window.

ui/compositor/test/in_process_context_provider.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/compositor/test/in_process_context_provider.h"
 
 #include "base/bind.h"
 #include "base/callback_helpers.h"
 #include "base/lazy_instance.h"
 #include "base/strings/stringprintf.h"
@@ skipping 75 matching lines @@
          context_thread_checker_.CalledOnValidThread());
 }
 
 bool InProcessContextProvider::BindToCurrentThread() {
   // This is called on the thread the context will be used.
   DCHECK(context_thread_checker_.CalledOnValidThread());
 
   if (!context_) {
     gfx::GpuPreference gpu_preference = gfx::PreferDiscreteGpu;
     context_.reset(gpu::GLInProcessContext::Create(
-        nullptr, /* service */
-        nullptr, /* surface */
-        true, /* is_offscreen */
-        window_,
-        gfx::Size(1, 1),
-        nullptr, /* share_context */
-        true, /* share_resources */
-        attribs_,
-        gpu_preference,
-        gpu::GLInProcessContextSharedMemoryLimits(),
-        nullptr,
-        nullptr));
+        nullptr,                           /* service */
+        nullptr,                           /* surface */
+        !window_,                          /* is_offscreen */
+        window_, gfx::Size(1, 1), nullptr, /* share_context */

[tfarina, 2015/02/28 00:19:28]

I know this is was formatted by clang. But one arg per line is much
better/readable imo!

[danakj, 2015/02/28 00:21:09]

i don't disagree.

+        true,                              /* share_resources */
+        attribs_, gpu_preference, gpu::GLInProcessContextSharedMemoryLimits(),
+        nullptr, nullptr));
 
     if (!context_)
       return false;
 
     context_->SetContextLostCallback(base::Bind(
         &InProcessContextProvider::OnLostContext, base::Unretained(this)));
   }
 
   capabilities_.gpu = context_->GetImplementation()->capabilities();
 
@@ skipping 104 matching lines @@
       return;
     destroyed_ = true;
   }
   if (!lost_context_callback_.is_null())
     base::ResetAndReturn(&lost_context_callback_).Run();
   if (gr_context_)
     gr_context_->abandonContext();
 }
 
 }  // namespace ui