Refactor isolate.py to be more functional and extensible

Refactor isolate.py to be more functional and extensible

- Works around poor handling of -- in optparse.
- Reuse sys.executable for python scripts.
- Moved all file handling code into tree_creator.py (which is a bit illnamed).
- Fixed hashtable mode to work without --outdir.
- Properly save the files mode.
- Properly save the file hash, only when needed.
- Always save the result file in json.

TBR=csharp@chromium.org
BUG=98640
TEST='GYP_DEFINES="$GYP_DEFINES tests_run=hashtable" build/gyp_chromium' works

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125784

[M-A Ruel, 2012-03-08 17:58:53]

Dependent on http://codereview.chromium.org/9621014/

[M-A Ruel, 2012-03-08 21:23:29]

GYP_DEFINES=tests_run=hashtable now archives in the output directory.
Technically it'd be better to save elsewhere but I want to get the ball rolling.
We can brainstorm about a good way to send this information. Maybe with an
environment variable.

[csharp, 2012-03-08 21:53:39]

https://chromiumcodereview.appspot.com/9638020/diff/6001/tools/isolate/isolat...
File tools/isolate/isolate.py (right):

https://chromiumcodereview.appspot.com/9638020/diff/6001/tools/isolate/isolat...
tools/isolate/isolate.py:51: if '--' in args:
Will optparse always be messing with us? Will this code get executed?

https://chromiumcodereview.appspot.com/9638020/diff/6001/tools/isolate/isolat...
tools/isolate/isolate.py:116: # Otherwise, an exception will be raised.
Where is this exception raised?

https://chromiumcodereview.appspot.com/9638020/diff/6001/tools/isolate/isolat...
File tools/isolate/isolate_test.py (right):

https://chromiumcodereview.appspot.com/9638020/diff/6001/tools/isolate/isolat...
tools/isolate/isolate_test.py:30: print
Why print a new line?

[M-A Ruel, 2012-03-08 21:56:40]

https://chromiumcodereview.appspot.com/9638020/diff/6001/tools/isolate/isolat...
File tools/isolate/isolate.py (right):

https://chromiumcodereview.appspot.com/9638020/diff/6001/tools/isolate/isolat...
tools/isolate/isolate.py:51: if '--' in args:
On 2012/03/08 21:53:39, csharp wrote:
> Will optparse always be messing with us? Will this code get executed?

Yes, it depends if the first non-argument is '--' or something else.

"./isolate.py --result foo -- bar" fails but
"./isolate.py --result foo baz -- bar" works ok.

https://chromiumcodereview.appspot.com/9638020/diff/6001/tools/isolate/isolat...
tools/isolate/isolate.py:116: # Otherwise, an exception will be raised.
On 2012/03/08 21:53:39, csharp wrote:
> Where is this exception raised?

Inside link_file() since outfile exists.

https://chromiumcodereview.appspot.com/9638020/diff/6001/tools/isolate/isolat...
File tools/isolate/isolate_test.py (right):

https://chromiumcodereview.appspot.com/9638020/diff/6001/tools/isolate/isolat...
tools/isolate/isolate_test.py:30: print
On 2012/03/08 21:53:39, csharp wrote:
> Why print a new line?

Makes reading the output much easier. It's only when -v is provided.

[csharp, 2012-03-08 22:36:59]

lgtm

[commit-bot: I haz the power, 2012-03-09 00:35:40]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[commit-bot: I haz the power, 2012-03-09 00:36:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/9638020/6001

[commit-bot: I haz the power, 2012-03-09 03:13:06]

Change committed as 125784