Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 9621014: Separate xvfb.py logic into its own script (Closed)

Created:
8 years, 9 months ago by M-A Ruel
Modified:
8 years, 9 months ago
CC:
chromium-reviews, pam+watch_chromium.org, brettw-cc_chromium.org, csharp
Visibility:
Public.

Description

Separate xvfb.py logic into its own script Add --flags flag to isolate.py. Fix issue with directory dependency. R=rogerta@chromium.org,mark@chromium.org BUG=117176 TEST="GYP_DEFINES=tests_run=run build/gyp_chromium; cd out/Debug; ninja base_unittests_run" work Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125737

Patch Set 1 #

Total comments: 2

Patch Set 2 : Made comment more logical, the test is run on non-linux OS #

Patch Set 3 : Add --files flag to isolate.py to work around gyp list singletons. #

Total comments: 1

Patch Set 4 : Fix invalid xdisplaycheck dependency #

Patch Set 5 : Fix support on Windows, quoting was a bit tricky #

Patch Set 6 : Save 5 lines, a variable is not needed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -11 lines) Patch
M base/base.gyp View 1 2 3 4 5 3 chunks +27 lines, -3 lines 0 comments Download
A testing/test_env.py View 1 chunk +36 lines, -0 lines 0 comments Download
A testing/xvfb.py View 1 1 chunk +108 lines, -0 lines 0 comments Download
M tools/isolate/isolate.py View 1 2 3 chunks +12 lines, -7 lines 0 comments Download
M tools/isolate/tree_creator.py View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
M-A Ruel
Just asking about the general design since there is an issue with gyp, isolate.py doesn't ...
8 years, 9 months ago (2012-03-07 19:41:32 UTC) #1
Roger Tawa OOO till Jul 10th
lgtm, with one comment below http://codereview.chromium.org/9621014/diff/1/testing/xvfb.py File testing/xvfb.py (right): http://codereview.chromium.org/9621014/diff/1/testing/xvfb.py#newcode92 testing/xvfb.py:92: return test_env.run_executable(cmd, env) should ...
8 years, 9 months ago (2012-03-07 19:51:27 UTC) #2
M-A Ruel
Tested with ninja, will run try job and inspect the output to make sure the ...
8 years, 9 months ago (2012-03-07 20:21:05 UTC) #3
M-A Ruel
Mark, can you look at base.gyp this morning. My next CL is dependent on this ...
8 years, 9 months ago (2012-03-08 16:08:54 UTC) #4
Mark Mentovai
LGTM
8 years, 9 months ago (2012-03-08 16:19:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/9621014/8001
8 years, 9 months ago (2012-03-08 16:21:50 UTC) #6
commit-bot: I haz the power
Try job failure for 9621014-8001 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 9 months ago (2012-03-08 19:33:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/9621014/8001
8 years, 9 months ago (2012-03-08 19:36:36 UTC) #8
commit-bot: I haz the power
Try job failure for 9621014-8001 (retry) on mac_rel for step "ui_tests" (clobber build). It's a ...
8 years, 9 months ago (2012-03-08 21:34:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/9621014/8001
8 years, 9 months ago (2012-03-08 21:37:42 UTC) #10
commit-bot: I haz the power
8 years, 9 months ago (2012-03-09 00:34:47 UTC) #11
Change committed as 125737

Powered by Google App Engine
This is Rietveld 408576698