Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 963553002: Automatically add NOTREECHECKS when uploading CLs from non master branches (Closed)

Created:
5 years, 10 months ago by rmistry
Modified:
5 years, 10 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Automatically add NOTREECHECKS when uploading CLs from non master branches These changes are possible due to the recently submitted depot_tools change https://codereview.chromium.org/949273002/ ('Add ability to specify and run post upload hooks'). BUG=skia: Committed: https://skia.googlesource.com/skia/+/896f3932c83c5685c440449912997651b567a182

Patch Set 1 : Initial upload #

Total comments: 1

Patch Set 2 : Addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -2 lines) Patch
M PRESUBMIT.py View 1 4 chunks +28 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
rmistry
5 years, 10 months ago (2015-02-26 18:38:18 UTC) #4
borenet
LGTM https://codereview.chromium.org/963553002/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/963553002/diff/1/PRESUBMIT.py#newcode301 PRESUBMIT.py:301: new_description += "\nNOTREECHECKS=true" For the moment, should we ...
5 years, 10 months ago (2015-02-26 18:41:43 UTC) #5
rmistry
On 2015/02/26 18:41:43, borenet wrote: > LGTM > > https://codereview.chromium.org/963553002/diff/1/PRESUBMIT.py > File PRESUBMIT.py (right): > ...
5 years, 10 months ago (2015-02-26 19:25:01 UTC) #11
borenet
LGTM
5 years, 10 months ago (2015-02-26 19:30:30 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/963553002/60001
5 years, 10 months ago (2015-02-26 19:32:10 UTC) #14
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 19:52:12 UTC) #15
Message was sent while issue was closed. 
Committed patchset #2 (id:60001) as
https://skia.googlesource.com/skia/+/896f3932c83c5685c440449912997651b567a182

Powered by Google App Engine
This is Rietveld 408576698