Add ability to specify and run post upload hooks

Add ability to specify and run post upload hooks.

Motivation: There are a few things we want to do in Skia infrastructure that is not possible to do without this functionality.
Eg1: If there is a change made to Skia's markdown then automatically include a 'DOCS_PREVIEW_URL=https://skia.org?cl=1234' in the CL's description.
Eg2: Automatically add 'NOTRY=true' for changes impacting things that do not need trybot runs.
Eg3: Include CL specific links to skia's perf (https://perf.skia.org/) and correctness (https://gold.skia.org/) servers.

BUG=chromium:462208
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294242

[rmistry, 2015-02-24 19:05:31]

rmistry@google.com changed reviewers:
+ iannucci@chromium.org

[rmistry, 2015-02-24 19:05:31]

Robbie, could you please review this for me?

[iannucci, 2015-02-25 22:31:04]

lgtm though I wonder if doing these asynchronously post-upload (e.g. directly on
the review site via a robot) would be better in the long run.

https://codereview.chromium.org/949273002/diff/20001/presubmit_support.py
File presubmit_support.py (right):

https://codereview.chromium.org/949273002/diff/20001/presubmit_support.py#new...
presubmit_support.py:1162: exec script_text in context
:(

Though I guess since it's already PRESUBMIT.py, it's not the very worst thing :(

https://codereview.chromium.org/949273002/diff/20001/presubmit_support.py#new...
presubmit_support.py:1318: for filename in presubmit_files:
is this in general -> specific, or specific -> general order?

e.g.

PRESUBMIT # 1
  foo/
    PRESUBMIT # 2

Does it go 2->1 or 1-2?

I'm thinking it should probably be 2->1

[rmistry, 2015-02-26 13:28:26]

Thanks for the review!

https://codereview.chromium.org/949273002/diff/20001/presubmit_support.py
File presubmit_support.py (right):

https://codereview.chromium.org/949273002/diff/20001/presubmit_support.py#new...
presubmit_support.py:1162: exec script_text in context
On 2015/02/25 22:31:04, iannucci wrote:
> :(
> 
> Though I guess since it's already PRESUBMIT.py, it's not the very worst thing
:(

Right, this also follows the same design as GetTryMastersExecuter above, so it
has consistency going for it, which is nice :)

https://codereview.chromium.org/949273002/diff/20001/presubmit_support.py#new...
presubmit_support.py:1318: for filename in presubmit_files:
On 2015/02/25 22:31:04, iannucci wrote:
> is this in general -> specific, or specific -> general order?
> 
> e.g.
> 
> PRESUBMIT # 1
>   foo/
>     PRESUBMIT # 2
> 
> Does it go 2->1 or 1-2?
> 
> I'm thinking it should probably be 2->1

Thats a good point. It was 1->2. Changed it to 2->1.

[rmistry, 2015-02-26 13:33:07]

Patchset #3 (id:40001) has been deleted

[rmistry, 2015-02-26 13:49:11]

The CQ bit was checked by rmistry@google.com

[rmistry, 2015-02-26 13:49:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
iannucci@chromium.org
Link to the patchset: https://codereview.chromium.org/949273002/#ps60001 (title:
"Call specific post upload hooks first")

[commit-bot: I haz the power, 2015-02-26 13:49:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/949273002/60001

[commit-bot: I haz the power, 2015-02-26 13:52:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-26 13:52:30]

Presubmit check for 949273002-60001 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
tests/gclient_smoketest.py (64.31s) failed
Ffatal: reference is not a tree: d63978e6202ca3075f4cef5acd464defe546b479
EE..............................................
======================================================================
ERROR: testBlinkDEPSChangeUsingGit (__main__.BlinkDEPSTransitionSmokeTest)
Like testBlinkDEPSChangeUsingGclient, but move the main project using
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1630, in testBlinkDEPSChangeUsingGit
    cwd=self.checkout_path)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
484, in check_call
    check_call_out(args, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
478, in check_call_out
    returncode, args, kwargs.get('cwd'), out[0], out[1])
CalledProcessError: Command git checkout -q
d63978e6202ca3075f4cef5acd464defe546b479 returned non-zero exit status 128 in
/tmp/trialpuTpR3/__main__.BlinkDEPSTransitionSmokeTest.testBlinkDEPSChangeUsingGit/src

======================================================================
ERROR: testBlinkLocalBranchesArePreserved
(__main__.BlinkDEPSTransitionSmokeTest)
Checks that the state of local git branches are effectively preserved
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1656, in
testBlinkLocalBranchesArePreserved
    self.CheckStatusPreMergePoint()
  File "tests/gclient_smoketest.py", line 1558, in CheckStatusPreMergePoint
    self.blink), self.blink_git_url)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/scm.py", line
121, in Capture
    cwd=cwd, stderr=subprocess2.PIPE, env=env, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
515, in check_output
    return check_call_out(args, stdout=PIPE, **kwargs)[0]
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
475, in check_call_out
    out, returncode = communicate(args, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
449, in communicate
    proc = Popen(args, **kwargs)
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/subprocess2.py", line
253, in __init__
    % (str(e), kwargs.get('cwd'), args[0]))
OSError: Execution failed with error: [Errno 2] No such file or directory:
'/tmp/trialpuTpR3/__main__.BlinkDEPSTransitionSmokeTest.testBlinkLocalBranchesArePreserved/src/third_party/WebKit'.
Check that
/tmp/trialpuTpR3/__main__.BlinkDEPSTransitionSmokeTest.testBlinkLocalBranchesArePreserved/src/third_party/WebKit
or git exist and have execution permission.

======================================================================
FAIL: testBlinkDEPSChangeUsingGclient (__main__.BlinkDEPSTransitionSmokeTest)
Checks that {src,blink} repos are consistent when syncing going back and
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1601, in
testBlinkDEPSChangeUsingGclient
    self.assertEqual(res[2], 0, 'DEPS change sync failed.')
AssertionError: DEPS change sync failed.

----------------------------------------------------------------------
Ran 49 tests in 64.093s

FAILED (failures=1, errors=2)


Presubmit checks took 179.7s to calculate.

[rmistry, 2015-02-26 13:59:55]

The CQ bit was checked by rmistry@google.com

[commit-bot: I haz the power, 2015-02-26 14:00:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/949273002/60001

[commit-bot: I haz the power, 2015-02-26 14:03:32]

Committed patchset #3 (id:60001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294242