Automatically add NOTREECHECKS when uploading CLs from non master branches

PRESUBMIT.py

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 
 """Top-level presubmit script for Skia.
 
 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
 for more details about the presubmit API built into gcl.
 """
@@ skipping 230 matching lines @@
             'one of: %s' % str(PUBLIC_API_OWNERS)))
   return results
 
 
 def PostUploadHook(cl, change, output_api):
   """git cl upload will call this hook after the issue is created/modified.
 
   This hook does the following:
   * Adds a link to preview docs changes if there are any docs changes in the CL.
   * Adds 'NOTRY=true' if the CL contains only docs changes.
+  * Adds 'NOTREECHECKS=true' for non master branch changes since they do not
+    need to be gated on the master branch's tree.
   """
 
   results = []
   atleast_one_docs_change = False
   all_docs_changes = True
   for affected_file in change.AffectedFiles():
     affected_file_path = affected_file.LocalPath()
     file_path, _ = os.path.splitext(affected_file_path)
     if 'site' == file_path.split(os.path.sep)[0]:
       atleast_one_docs_change = True
@@ skipping 22 matching lines @@
     # description if it does not already exist there.
     if atleast_one_docs_change and not re.search(
         r'^DOCS_PREVIEW=.*', original_description, re.M | re.I):
       # Automatically add a link to where the docs can be previewed.
       new_description += '\nDOCS_PREVIEW= %s%s' % (DOCS_PREVIEW_URL, issue)
       results.append(
           output_api.PresubmitNotifyResult(
               'Automatically added a link to preview the docs changes to the '
               'CL\'s description'))
 
+    # If the target ref is not master then add NOTREECHECKS=true to the CL's
+    # description if it does not already exist there.
+    target_ref = rietveld_obj.get_issue_properties(issue, False).get(
+        'target_ref', '')
+    if target_ref != 'refs/heads/master' and not re.search(
+        r'^NOTREECHECKS=true$', original_description, re.M | re.I):
+      new_description += "\nNOTREECHECKS=true"

[borenet, 2015/02/26 18:41:43]

For the moment, should we also add NOTRY=true since trybots don't yet work for
branches?

+      results.append(
+          output_api.PresubmitNotifyResult(
+              'Branch changes do not need to rely on the master branch\'s tree '
+              'status. Automatically added \'NOTREECHECKS=true\' to the CL\'s '
+              'description'))
+
     # If the description has changed update it.
     if new_description != original_description:
       rietveld_obj.update_description(issue, new_description)
 
     return results
 
 
 def CheckChangeOnCommit(input_api, output_api):
   """Presubmit checks for the change on commit.
 
   The following are the presubmit checks:
   * Check change has one and only one EOL.
   * Ensures that the Skia tree is open in
     http://skia-tree-status.appspot.com/. Shows a warning if it is in 'Caution'
     state and an error if it is in 'Closed' state.
   """
   results = []
   results.extend(_CommonChecks(input_api, output_api))
   results.extend(
       _CheckTreeStatus(input_api, output_api, json_url=(
           SKIA_TREE_STATUS_URL + '/banner-status?format=json')))
   results.extend(_CheckLGTMsForPublicAPI(input_api, output_api))
   results.extend(_CheckOwnerIsInAuthorsFile(input_api, output_api))
   return results