Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 963313002: [Telemetry] Add interaction_record field to Value (Closed)

Created:
5 years, 9 months ago by eakuefner
Modified:
5 years, 9 months ago
Reviewers:
nednguyen, dtu
CC:
chromium-reviews, sullivan, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Add interaction_record field to Value This change adds a field called interaction_record to values, which will specify the label of the interaction_record with which the value is associated, if it was generated by TimelineBasedMeasurement. R=nednguyen,dtu BUG=461101 Committed: https://crrev.com/579346a58192cd767faae7ee20857fb7c6b24496 Cr-Commit-Position: refs/heads/master@{#319155}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address Ned's comments + add merging + tests #

Patch Set 3 : misc typo fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -81 lines) Patch
M tools/telemetry/telemetry/value/__init__.py View 1 2 5 chunks +20 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/value/failure.py View 3 chunks +4 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/value/histogram.py View 1 2 4 chunks +13 lines, -9 lines 0 comments Download
M tools/telemetry/telemetry/value/list_of_scalar_values.py View 1 6 chunks +12 lines, -6 lines 0 comments Download
M tools/telemetry/telemetry/value/list_of_string_values.py View 1 6 chunks +20 lines, -14 lines 0 comments Download
M tools/telemetry/telemetry/value/merge_values_unittest.py View 1 1 chunk +12 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/value/scalar.py View 1 6 chunks +19 lines, -12 lines 0 comments Download
M tools/telemetry/telemetry/value/skip.py View 2 chunks +4 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/value/string.py View 1 6 chunks +19 lines, -12 lines 0 comments Download
M tools/telemetry/telemetry/value/trace.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/value/value_unittest.py View 1 2 chunks +79 lines, -18 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
eakuefner
I plan to remove the wrapper class that's currently in TBM in a following change.
5 years, 9 months ago (2015-02-27 23:50:58 UTC) #1
nednguyen
https://codereview.chromium.org/963313002/diff/1/tools/telemetry/telemetry/value/__init__.py File tools/telemetry/telemetry/value/__init__.py (right): https://codereview.chromium.org/963313002/diff/1/tools/telemetry/telemetry/value/__init__.py#newcode61 tools/telemetry/telemetry/value/__init__.py:61: this value is associated. s/The label/The string label.
5 years, 9 months ago (2015-02-28 01:02:24 UTC) #2
nednguyen
https://codereview.chromium.org/963313002/diff/1/tools/telemetry/telemetry/value/__init__.py File tools/telemetry/telemetry/value/__init__.py (right): https://codereview.chromium.org/963313002/diff/1/tools/telemetry/telemetry/value/__init__.py#newcode90 tools/telemetry/telemetry/value/__init__.py:90: def MergeLikeValuesFromSamePage(cls, values): How does interaction record fit into ...
5 years, 9 months ago (2015-02-28 01:29:34 UTC) #3
eakuefner
https://codereview.chromium.org/963313002/diff/1/tools/telemetry/telemetry/value/__init__.py File tools/telemetry/telemetry/value/__init__.py (right): https://codereview.chromium.org/963313002/diff/1/tools/telemetry/telemetry/value/__init__.py#newcode61 tools/telemetry/telemetry/value/__init__.py:61: this value is associated. On 2015/02/28 01:02:24, nednguyen wrote: ...
5 years, 9 months ago (2015-03-02 23:46:57 UTC) #4
nednguyen
lgtm We still need to do some work on value/summary.py but this patch is a ...
5 years, 9 months ago (2015-03-04 21:01:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/963313002/40001
5 years, 9 months ago (2015-03-04 21:06:41 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-04 23:10:02 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 23:11:01 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/579346a58192cd767faae7ee20857fb7c6b24496
Cr-Commit-Position: refs/heads/master@{#319155}

Powered by Google App Engine
This is Rietveld 408576698