Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: tools/telemetry/telemetry/value/skip.py

Issue 963313002: [Telemetry] Add interaction_record field to Value (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: misc typo fixes Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/value/scalar.py ('k') | tools/telemetry/telemetry/value/string.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/value/skip.py
diff --git a/tools/telemetry/telemetry/value/skip.py b/tools/telemetry/telemetry/value/skip.py
index 2b03725e1cf0fad17e5e35d72a39beb34c4e4fcd..eb86af0b5c02bee343280e0b7da5faf16438a9eb 100644
--- a/tools/telemetry/telemetry/value/skip.py
+++ b/tools/telemetry/telemetry/value/skip.py
@@ -14,7 +14,7 @@ class SkipValue(value_module.Value):
page: The skipped page object.
reason: The string reason the page was skipped.
"""
- super(SkipValue, self).__init__(page, 'skip', '', True, description)
+ super(SkipValue, self).__init__(page, 'skip', '', True, description, None)
self._reason = reason
def __repr__(self):
@@ -54,10 +54,11 @@ class SkipValue(value_module.Value):
kwargs = value_module.Value.GetConstructorKwArgs(value_dict, page_dict)
del kwargs['name']
del kwargs['units']
- important = kwargs.get('important', None)
- if important != None:
+ if 'important' in kwargs:
del kwargs['important']
kwargs['reason'] = value_dict['reason']
+ if 'interaction_record' in kwargs:
+ del kwargs['interaction_record']
return SkipValue(**kwargs)
« no previous file with comments | « tools/telemetry/telemetry/value/scalar.py ('k') | tools/telemetry/telemetry/value/string.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698