Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: tools/telemetry/telemetry/value/failure.py

Issue 963313002: [Telemetry] Add interaction_record field to Value (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: misc typo fixes Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/value/__init__.py ('k') | tools/telemetry/telemetry/value/histogram.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/value/failure.py
diff --git a/tools/telemetry/telemetry/value/failure.py b/tools/telemetry/telemetry/value/failure.py
index 3b51b61c7d89f914660a4ca4532d2747801519ae..aa074246e41d9e291ac964c8797cd207e4f5a707 100644
--- a/tools/telemetry/telemetry/value/failure.py
+++ b/tools/telemetry/telemetry/value/failure.py
@@ -10,7 +10,7 @@ from telemetry import value as value_module
class FailureValue(value_module.Value):
- def __init__(self, page, exc_info, description=None):
+ def __init__(self, page, exc_info, description=None, interaction_record=None):
"""A value representing a failure when running the page.
Args:
@@ -19,7 +19,8 @@ class FailureValue(value_module.Value):
this failure.
"""
exc_type = exc_info[0].__name__
- super(FailureValue, self).__init__(page, exc_type, '', True, description)
+ super(FailureValue, self).__init__(page, exc_type, '', True, description,
+ interaction_record)
self._exc_info = exc_info
@classmethod
@@ -81,8 +82,7 @@ class FailureValue(value_module.Value):
kwargs = value_module.Value.GetConstructorKwArgs(value_dict, page_dict)
del kwargs['name']
del kwargs['units']
- important = kwargs.get('important', None)
- if important != None:
+ if 'important' in kwargs:
del kwargs['important']
kwargs['exc_info'] = FailureValue._GetExcInfoFromMessage(
value_dict['value'])
« no previous file with comments | « tools/telemetry/telemetry/value/__init__.py ('k') | tools/telemetry/telemetry/value/histogram.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698