components/autofill/core/browser/autocomplete_history_manager.h - Issue 962673004: [Autofill/Autocomplete Feature] Substring matching instead of prefix matching.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autocomplete_history_manager.h

Issue 962673004: [Autofill/Autocomplete Feature] Substring matching instead of prefix matching. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added comments in autocomplete_history_manager.cc. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/content/renderer/password_autofill_agent.cc ('K') | « components/autofill/content/renderer/password_autofill_agent.cc ('k') | components/autofill/core/browser/autocomplete_history_manager.cc » ('j') | components/autofill/core/browser/autocomplete_history_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autocomplete_history_manager.h

diff --git a/components/autofill/core/browser/autocomplete_history_manager.h b/components/autofill/core/browser/autocomplete_history_manager.h

index 151b2e797ce5eb44f282509c1363ba0956844cc0..5052c75631b325a8b8336ee525a9679119059d4d 100644

--- a/components/autofill/core/browser/autocomplete_history_manager.h

+++ b/components/autofill/core/browser/autocomplete_history_manager.h

@@ -71,6 +71,9 @@ class AutocompleteHistoryManager : public WebDataServiceConsumer {

// back. We also store the autofill results so we can send them together.

WebDataServiceBase::Handle pending_query_handle_;

int query_id_;

+ // Field contents.

+ base::string16 pending_query_prefix_;

please use gerrit instead 2015/06/29 22:06:29 Let's call it "last_query_prefix" and put a newlin

Pritam Nikam 2015/06/30 15:05:50 As we can move logic to SQL, removing it.

std::vector<Suggestion> autofill_suggestions_;

// Delegate to perform external processing (display, selection) on