Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Side by Side Diff: components/autofill/core/browser/autocomplete_history_manager.h

Issue 962673004: [Autofill/Autocomplete Feature] Substring matching instead of prefix matching. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added comments in autocomplete_history_manager.cc. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOCOMPLETE_HISTORY_MANAGER_H_ 5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOCOMPLETE_HISTORY_MANAGER_H_
6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOCOMPLETE_HISTORY_MANAGER_H_ 6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOCOMPLETE_HISTORY_MANAGER_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/gtest_prod_util.h" 10 #include "base/gtest_prod_util.h"
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 private: 64 private:
65 // Provides driver-level context. Must outlive this object. 65 // Provides driver-level context. Must outlive this object.
66 AutofillDriver* driver_; 66 AutofillDriver* driver_;
67 scoped_refptr<AutofillWebDataService> database_; 67 scoped_refptr<AutofillWebDataService> database_;
68 68
69 // When the manager makes a request from WebDataServiceBase, the database is 69 // When the manager makes a request from WebDataServiceBase, the database is
70 // queried on another thread, we record the query handle until we get called 70 // queried on another thread, we record the query handle until we get called
71 // back. We also store the autofill results so we can send them together. 71 // back. We also store the autofill results so we can send them together.
72 WebDataServiceBase::Handle pending_query_handle_; 72 WebDataServiceBase::Handle pending_query_handle_;
73 int query_id_; 73 int query_id_;
74
75 // Field contents.
76 base::string16 pending_query_prefix_;
please use gerrit instead 2015/06/29 22:06:29 Let's call it "last_query_prefix" and put a newlin
Pritam Nikam 2015/06/30 15:05:50 As we can move logic to SQL, removing it.
74 std::vector<Suggestion> autofill_suggestions_; 77 std::vector<Suggestion> autofill_suggestions_;
75 78
76 // Delegate to perform external processing (display, selection) on 79 // Delegate to perform external processing (display, selection) on
77 // our behalf. Weak. 80 // our behalf. Weak.
78 AutofillExternalDelegate* external_delegate_; 81 AutofillExternalDelegate* external_delegate_;
79 82
80 // Delegate to provide whether or not autocomplete functionality is enabled. 83 // Delegate to provide whether or not autocomplete functionality is enabled.
81 AutofillClient* const autofill_client_; 84 AutofillClient* const autofill_client_;
82 85
83 // Whether IPC is sent. 86 // Whether IPC is sent.
84 bool send_ipc_; 87 bool send_ipc_;
85 88
86 DISALLOW_COPY_AND_ASSIGN(AutocompleteHistoryManager); 89 DISALLOW_COPY_AND_ASSIGN(AutocompleteHistoryManager);
87 }; 90 };
88 91
89 } // namespace autofill 92 } // namespace autofill
90 93
91 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOCOMPLETE_HISTORY_MANAGER_H_ 94 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOCOMPLETE_HISTORY_MANAGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698