[Autofill/Autocomplete Feature] Substring matching instead of prefix matching.

components/autofill/content/renderer/password_autofill_agent.cc

Index: components/autofill/content/renderer/password_autofill_agent.cc
diff --git a/components/autofill/content/renderer/password_autofill_agent.cc b/components/autofill/content/renderer/password_autofill_agent.cc
index f0dcefd80475482fc096bf1c14839fd18cab75d4..447db60a1aed864cec67998ac0def4c35a337548 100644
--- a/components/autofill/content/renderer/password_autofill_agent.cc
+++ b/components/autofill/content/renderer/password_autofill_agent.cc
@@ -17,6 +17,7 @@
 #include "components/autofill/content/renderer/renderer_save_password_progress_logger.h"
 #include "components/autofill/core/common/autofill_constants.h"
 #include "components/autofill/core/common/autofill_switches.h"
+#include "components/autofill/core/common/autofill_util.h"
 #include "components/autofill/core/common/form_field_data.h"
 #include "components/autofill/core/common/password_form.h"
 #include "components/autofill/core/common/password_form_fill_data.h"
@@ -225,7 +226,8 @@ bool DoUsernamesMatch(const base::string16& username1,
                       bool exact_match) {
   if (exact_match)
     return username1 == username2;
-  return base::StartsWith(username1, username2, true);
+  return base::StartsWith(username1, username2, true) ||
+         ContainsTokenThatStartsWith(username1, username2, true);
 }
 
 // Returns |true| if the given element is editable. Otherwise, returns |false|.
@@ -415,8 +417,14 @@ bool FillUserNameAndPassword(
     username_element->setAutofilled(true);
 
     if (set_selection) {
-      username_element->setSelectionRange(current_username.length(),
-                                          username.length());
+      if (IsFeatureSubstringMatchEnabled()) {
+        size_t start =
+            autofill::GetTextSelectionStart(username, current_username);
+        username_element->setSelectionRange(start, username.length());
+      } else {
+        username_element->setSelectionRange(current_username.length(),
+                                            username.length());
+      }
     }
   } else if (current_username != username) {
     // If the username can't be filled and it doesn't match a saved password
@@ -791,14 +799,13 @@ bool PasswordAutofillAgent::PreviewSuggestion(
     return false;
   }
 
+  base::string16 current_username = username_element.value();
+  base::string16 suggested_username = username;
   was_username_autofilled_ = username_element.isAutofilled();
   username_selection_start_ = username_element.selectionStart();
   username_element.setSuggestedValue(username);
   username_element.setAutofilled(true);
-  username_element.setSelectionRange(
-      username_selection_start_,
-      username_element.suggestedValue().length());
-
+  ::autofill::PreviewSuggestion(suggested_username, &username_element);

[please use gerrit instead, 2015/06/29 22:06:28]

Why "::autofill::"?

[Pritam Nikam, 2015/06/30 15:05:50]

We are already inside |PasswordAutofillAgent::PreviewSuggestion()|. For
compiler, it's confusing.

[please use gerrit instead, 2015/06/30 19:06:22]

Acknowledged.

   was_password_autofilled_ = password_info->password_field.isAutofilled();
   password_info->password_field.setSuggestedValue(password);
   password_info->password_field.setAutofilled(true);