Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 962543003: Simplify RenderLayer's handling of filters. (Closed)

Created:
5 years, 10 months ago by ojan
Modified:
5 years, 10 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Simplify RenderLayer's handling of filters. -Remove RenderLayerFilterInfo. It was just a static map for FilterEffectRenderers. Instead, put the FilterEffectRenderer directly on RenderLayer. -Make FilterEffectRenderer not be RefCounted. This involved deleting a ton of dead code around ReferenceFilters since they were the other subclass of Filter. As best I can tell, reference filters are already don't parse in Sky, so this should just be removing dead code. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ffcae6d012fbc84b4d055b47c42311511e9c63f2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -584 lines) Patch
M sky/engine/core/core.gni View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/css/CSSComputedStyleDeclaration.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/core/css/CSSFilterValue.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/CSSFilterValue.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/css/resolver/FilterOperationResolver.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/core/frame/FrameView.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/FilterEffectRenderer.h View 2 chunks +4 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/FilterEffectRenderer.cpp View 2 chunks +4 lines, -9 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.h View 4 chunks +2 lines, -16 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.cpp View 4 chunks +4 lines, -31 lines 0 comments Download
D sky/engine/core/rendering/RenderLayerFilterInfo.h View 1 chunk +0 lines, -74 lines 0 comments Download
D sky/engine/core/rendering/RenderLayerFilterInfo.cpp View 1 chunk +0 lines, -105 lines 0 comments Download
M sky/engine/platform/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/platform/graphics/filters/Filter.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/platform/graphics/filters/FilterOperation.h View 5 chunks +1 line, -48 lines 0 comments Download
M sky/engine/platform/graphics/filters/FilterOperations.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/platform/graphics/filters/FilterOperations.cpp View 2 chunks +0 lines, -24 lines 0 comments Download
D sky/engine/platform/graphics/filters/ImageFilterBuilderTest.cpp View 1 chunk +0 lines, -125 lines 0 comments Download
D sky/engine/platform/graphics/filters/ReferenceFilter.h View 1 chunk +0 lines, -68 lines 0 comments Download
D sky/engine/platform/graphics/filters/ReferenceFilter.cpp View 1 chunk +0 lines, -55 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 10 months ago (2015-02-26 22:31:07 UTC) #2
ojan
5 years, 10 months ago (2015-02-26 23:38:19 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
ffcae6d012fbc84b4d055b47c42311511e9c63f2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698