Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1619)

Unified Diff: sky/engine/platform/graphics/filters/FilterOperations.cpp

Issue 962543003: Simplify RenderLayer's handling of filters. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/platform/graphics/filters/FilterOperations.cpp
diff --git a/sky/engine/platform/graphics/filters/FilterOperations.cpp b/sky/engine/platform/graphics/filters/FilterOperations.cpp
index 4f6acb7c2dbdddeae15d5867004e369dcf1cd690..6dc704a6e1206ffaad89ded6f1ae442eaf7fe617 100644
--- a/sky/engine/platform/graphics/filters/FilterOperations.cpp
+++ b/sky/engine/platform/graphics/filters/FilterOperations.cpp
@@ -88,15 +88,6 @@ bool FilterOperations::canInterpolateWith(const FilterOperations& other) const
return true;
}
-bool FilterOperations::hasReferenceFilter() const
-{
- for (size_t i = 0; i < m_operations.size(); ++i) {
- if (m_operations.at(i)->type() == FilterOperation::REFERENCE)
- return true;
- }
- return false;
-}
-
FilterOutsets FilterOperations::outsets() const
{
FilterOutsets totalOutsets;
@@ -123,21 +114,6 @@ FilterOutsets FilterOperations::outsets() const
totalOutsets += outsets;
break;
}
- case FilterOperation::REFERENCE: {
- ReferenceFilterOperation* referenceOperation = toReferenceFilterOperation(filterOperation);
- if (referenceOperation->filter() && referenceOperation->filter()->lastEffect()) {
- FloatRect outsetRect(0, 0, 1, 1);
- outsetRect = referenceOperation->filter()->lastEffect()->mapRectRecursive(outsetRect);
- FilterOutsets outsets(
- std::max(0.0f, -outsetRect.y()),
- std::max(0.0f, outsetRect.x() + outsetRect.width() - 1),
- std::max(0.0f, outsetRect.y() + outsetRect.height() - 1),
- std::max(0.0f, -outsetRect.x())
- );
- totalOutsets += outsets;
- }
- break;
- }
default:
break;
}

Powered by Google App Engine
This is Rietveld 408576698