Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Unified Diff: sky/engine/core/rendering/FilterEffectRenderer.cpp

Issue 962543003: Simplify RenderLayer's handling of filters. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/rendering/FilterEffectRenderer.h ('k') | sky/engine/core/rendering/RenderBox.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/rendering/FilterEffectRenderer.cpp
diff --git a/sky/engine/core/rendering/FilterEffectRenderer.cpp b/sky/engine/core/rendering/FilterEffectRenderer.cpp
index f8635c9d59cd135f7cb54e898283de0ec5900255..558c25f6547b77231026137e93e4854f9e5431fc 100644
--- a/sky/engine/core/rendering/FilterEffectRenderer.cpp
+++ b/sky/engine/core/rendering/FilterEffectRenderer.cpp
@@ -87,9 +87,6 @@ bool FilterEffectRenderer::build(RenderObject* renderer, const FilterOperations&
RefPtr<FilterEffect> effect;
FilterOperation* filterOperation = operations.operations().at(i).get();
switch (filterOperation->type()) {
- case FilterOperation::REFERENCE: {
- break;
- }
case FilterOperation::GRAYSCALE: {
Vector<float> inputParameters;
double oneMinusAmount = clampTo(1 - toBasicColorMatrixFilterOperation(filterOperation)->amount(), 0.0, 1.0);
@@ -220,12 +217,10 @@ bool FilterEffectRenderer::build(RenderObject* renderer, const FilterOperations&
}
if (effect) {
- if (filterOperation->type() != FilterOperation::REFERENCE) {
- // Unlike SVG, filters applied here should not clip to their primitive subregions.
- effect->setClipsToBounds(false);
- effect->setOperatingColorSpace(ColorSpaceDeviceRGB);
- effect->inputEffects().append(previousEffect);
- }
+ // Unlike SVG, filters applied here should not clip to their primitive subregions.
+ effect->setClipsToBounds(false);
+ effect->setOperatingColorSpace(ColorSpaceDeviceRGB);
+ effect->inputEffects().append(previousEffect);
previousEffect = effect.release();
}
}
« no previous file with comments | « sky/engine/core/rendering/FilterEffectRenderer.h ('k') | sky/engine/core/rendering/RenderBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698