Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: Source/modules/webmidi/MIDIAccessInitializer.cpp

Issue 962523005: Web MIDI: add open() and close() to MIDIPort (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: review #14 Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/webmidi/MIDIAccessInitializer.h ('k') | Source/modules/webmidi/MIDIAccessor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/webmidi/MIDIAccessInitializer.cpp
diff --git a/Source/modules/webmidi/MIDIAccessInitializer.cpp b/Source/modules/webmidi/MIDIAccessInitializer.cpp
index 8890a80a6985cf97f4d51b3f360ce104c057cbdb..5aabc86856a0edd6dcb045e557555f7c2ae1f479 100644
--- a/Source/modules/webmidi/MIDIAccessInitializer.cpp
+++ b/Source/modules/webmidi/MIDIAccessInitializer.cpp
@@ -17,6 +17,8 @@
namespace blink {
+using PortState = WebMIDIAccessorClient::MIDIPortState;
+
MIDIAccessInitializer::MIDIAccessInitializer(ScriptState* scriptState, const MIDIOptions& options)
: ScriptPromiseResolver(scriptState)
, m_requestSysex(false)
@@ -93,19 +95,19 @@ ScriptPromise MIDIAccessInitializer::start()
return promise;
}
-void MIDIAccessInitializer::didAddInputPort(const String& id, const String& manufacturer, const String& name, const String& version, bool isActive)
+void MIDIAccessInitializer::didAddInputPort(const String& id, const String& manufacturer, const String& name, const String& version, PortState state)
{
ASSERT(m_accessor);
- m_portDescriptors.append(PortDescriptor(id, manufacturer, name, MIDIPort::MIDIPortTypeInput, version, isActive));
+ m_portDescriptors.append(PortDescriptor(id, manufacturer, name, MIDIPort::MIDIPortTypeInput, version, state));
}
-void MIDIAccessInitializer::didAddOutputPort(const String& id, const String& manufacturer, const String& name, const String& version, bool isActive)
+void MIDIAccessInitializer::didAddOutputPort(const String& id, const String& manufacturer, const String& name, const String& version, PortState state)
{
ASSERT(m_accessor);
- m_portDescriptors.append(PortDescriptor(id, manufacturer, name, MIDIPort::MIDIPortTypeOutput, version, isActive));
+ m_portDescriptors.append(PortDescriptor(id, manufacturer, name, MIDIPort::MIDIPortTypeOutput, version, state));
}
-void MIDIAccessInitializer::didSetInputPortState(unsigned portIndex, bool isActive)
+void MIDIAccessInitializer::didSetInputPortState(unsigned portIndex, PortState state)
{
// didSetInputPortState() is not allowed to call before didStartSession()
// is called. Once didStartSession() is called, MIDIAccessorClient methods
@@ -113,7 +115,7 @@ void MIDIAccessInitializer::didSetInputPortState(unsigned portIndex, bool isActi
ASSERT_NOT_REACHED();
}
-void MIDIAccessInitializer::didSetOutputPortState(unsigned portIndex, bool isActive)
+void MIDIAccessInitializer::didSetOutputPortState(unsigned portIndex, PortState state)
{
// See comments on didSetInputPortState().
ASSERT_NOT_REACHED();
« no previous file with comments | « Source/modules/webmidi/MIDIAccessInitializer.h ('k') | Source/modules/webmidi/MIDIAccessor.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698