Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1235)

Unified Diff: Source/modules/webmidi/MIDIAccessor.cpp

Issue 962523005: Web MIDI: add open() and close() to MIDIPort (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: review #14 Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/webmidi/MIDIAccessInitializer.cpp ('k') | Source/modules/webmidi/MIDIAccessorClient.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/webmidi/MIDIAccessor.cpp
diff --git a/Source/modules/webmidi/MIDIAccessor.cpp b/Source/modules/webmidi/MIDIAccessor.cpp
index 5a69a571ea3e0292c9db9f20b7bc8505654b89a2..905eb0e6f4cc7d124c2a4f55c1f2bcc981f61ee2 100644
--- a/Source/modules/webmidi/MIDIAccessor.cpp
+++ b/Source/modules/webmidi/MIDIAccessor.cpp
@@ -67,26 +67,22 @@ void MIDIAccessor::sendMIDIData(unsigned portIndex, const unsigned char* data, s
void MIDIAccessor::didAddInputPort(const WebString& id, const WebString& manufacturer, const WebString& name, const WebString& version, MIDIPortState state)
{
- // FIXME: Update to support complete MIDIPortState in MIDIPort.
- m_client->didAddInputPort(id, manufacturer, name, version, state != MIDIPortStateDisconnected);
+ m_client->didAddInputPort(id, manufacturer, name, version, state);
}
void MIDIAccessor::didAddOutputPort(const WebString& id, const WebString& manufacturer, const WebString& name, const WebString& version, MIDIPortState state)
{
- // FIXME: Update to support complete MIDIPortState in MIDIPort.
- m_client->didAddOutputPort(id, manufacturer, name, version, state != MIDIPortStateDisconnected);
+ m_client->didAddOutputPort(id, manufacturer, name, version, state);
}
void MIDIAccessor::didSetInputPortState(unsigned portIndex, MIDIPortState state)
{
- // FIXME: Update to support complete MIDIPortState in MIDIPort.
- m_client->didSetInputPortState(portIndex, state != MIDIPortStateDisconnected);
+ m_client->didSetInputPortState(portIndex, state);
}
void MIDIAccessor::didSetOutputPortState(unsigned portIndex, MIDIPortState state)
{
- // FIXME: Update to support complete MIDIPortState in MIDIPort.
- m_client->didSetOutputPortState(portIndex, state != MIDIPortStateDisconnected);
+ m_client->didSetOutputPortState(portIndex, state);
}
void MIDIAccessor::didStartSession(bool success, const WebString& error, const WebString& message)
« no previous file with comments | « Source/modules/webmidi/MIDIAccessInitializer.cpp ('k') | Source/modules/webmidi/MIDIAccessorClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698