Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: Source/modules/webmidi/MIDIAccessInitializer.h

Issue 962523005: Web MIDI: add open() and close() to MIDIPort (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: review #14 Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/webmidi/MIDIAccess.cpp ('k') | Source/modules/webmidi/MIDIAccessInitializer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/webmidi/MIDIAccessInitializer.h
diff --git a/Source/modules/webmidi/MIDIAccessInitializer.h b/Source/modules/webmidi/MIDIAccessInitializer.h
index de9d3e3159991322496dfe5a2c3d696b5438fe58..9fd9d4c8b5ed3e1ccca57dcdce3d10b6ec576367 100644
--- a/Source/modules/webmidi/MIDIAccessInitializer.h
+++ b/Source/modules/webmidi/MIDIAccessInitializer.h
@@ -27,15 +27,15 @@ public:
String name;
MIDIPort::MIDIPortTypeCode type;
String version;
- bool isActive;
+ MIDIAccessor::MIDIPortState state;
- PortDescriptor(const String& id, const String& manufacturer, const String& name, MIDIPort::MIDIPortTypeCode type, const String& version, bool isActive)
+ PortDescriptor(const String& id, const String& manufacturer, const String& name, MIDIPort::MIDIPortTypeCode type, const String& version, MIDIAccessor::MIDIPortState state)
: id(id)
, manufacturer(manufacturer)
, name(name)
, type(type)
, version(version)
- , isActive(isActive) { }
+ , state(state) { }
};
static ScriptPromise start(ScriptState* scriptState, const MIDIOptions& options)
@@ -46,15 +46,15 @@ public:
return resolver->start();
}
- virtual ~MIDIAccessInitializer();
+ ~MIDIAccessInitializer() override;
// MIDIAccessorClient
- virtual void didAddInputPort(const String& id, const String& manufacturer, const String& name, const String& version, bool isActive) override;
- virtual void didAddOutputPort(const String& id, const String& manufacturer, const String& name, const String& version, bool isActive) override;
- virtual void didSetInputPortState(unsigned portIndex, bool isActive) override;
- virtual void didSetOutputPortState(unsigned portIndex, bool isActive) override;
- virtual void didStartSession(bool success, const String& error, const String& message) override;
- virtual void didReceiveMIDIData(unsigned portIndex, const unsigned char* data, size_t length, double timeStamp) override { }
+ void didAddInputPort(const String& id, const String& manufacturer, const String& name, const String& version, MIDIAccessor::MIDIPortState) override;
+ void didAddOutputPort(const String& id, const String& manufacturer, const String& name, const String& version, MIDIAccessor::MIDIPortState) override;
+ void didSetInputPortState(unsigned portIndex, MIDIAccessor::MIDIPortState) override;
+ void didSetOutputPortState(unsigned portIndex, MIDIAccessor::MIDIPortState) override;
+ void didStartSession(bool success, const String& error, const String& message) override;
+ void didReceiveMIDIData(unsigned portIndex, const unsigned char* data, size_t length, double timeStamp) override { }
void resolveSysexPermission(bool allowed);
SecurityOrigin* securityOrigin() const;
« no previous file with comments | « Source/modules/webmidi/MIDIAccess.cpp ('k') | Source/modules/webmidi/MIDIAccessInitializer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698