[net]: Disable SdchOwner's MemoryPressureListener to investigate http://crbug.com/447208.

[net]: Disable SdchOwner's MemoryPressureListener to investigate http://crbug.com/447208.

BUG=447208
NOPRESUBMIT=true

Committed: https://crrev.com/9ead5677d87d725b68971f0464a423e7af22634c
Cr-Commit-Position: refs/heads/master@{#318575}

[rmcilroy, 2015-02-27 19:58:02]

rmcilroy@chromium.org changed reviewers:
+ rdsmith@chromium.org

[rmcilroy, 2015-02-27 19:58:03]

rdsmith: I'd like to remove the SdchOwner's memory pressure listener and merge
this change into m41 to try and fix the crash in crbug.com/447208.  We need this
change in before monday to make the m41 stable release date.  Could you please
take a look, thanks.

[rmcilroy, 2015-02-27 22:52:13]

rmcilroy@chromium.org changed reviewers:
+ davidben@chromium.org

[rmcilroy, 2015-02-27 22:52:14]

David: It looks like Randy is OOO today - could you have a look at this change
please?  This is to try and work around a Release-Block-Stable bug on m41, so we
would really like it in Dev over the weekend so I can merge it into m41 on
Monday before the final stable cut point.  Could you take a look please?

[davidben, 2015-02-27 23:29:34]

https://codereview.chromium.org/962313003/diff/1/net/sdch/sdch_owner.cc
File net/sdch/sdch_owner.cc (right):

https://codereview.chromium.org/962313003/diff/1/net/sdch/sdch_owner.cc#newco...
net/sdch/sdch_owner.cc:105: #endif
Since we'd presumably flip this back from a scoped_ptr anyway if we were to undo
this, let's just remove these lines (and the member) and leave a TODO comment
rather than play games with #if 0. We've got version control for a reason.

[rmcilroy, 2015-02-28 00:08:50]

On 2015/02/27 23:29:34, David Benjamin wrote:
> https://codereview.chromium.org/962313003/diff/1/net/sdch/sdch_owner.cc
> File net/sdch/sdch_owner.cc (right):
> 
>
https://codereview.chromium.org/962313003/diff/1/net/sdch/sdch_owner.cc#newco...
> net/sdch/sdch_owner.cc:105: #endif
> Since we'd presumably flip this back from a scoped_ptr anyway if we were to
undo
> this, let's just remove these lines (and the member) and leave a TODO comment
> rather than play games with #if 0. We've got version control for a reason.

OK I've removed the field and #if 0 (I wasn't a fan of the #if 0 either), but
it's led to a bit of a funky #ifdefing in the constructor due to the dangling
'{'.  Do you prefer this better?

Thansk for the review, PTAL.

[davidben, 2015-02-28 00:18:18]

lgtm since Randy is away and we want the Dev channel numbers, but double-check
with him before you merge this.

https://codereview.chromium.org/962313003/diff/20001/net/sdch/sdch_owner.cc
File net/sdch/sdch_owner.cc (right):

https://codereview.chromium.org/962313003/diff/20001/net/sdch/sdch_owner.cc#n...
net/sdch/sdch_owner.cc:100: #endif
Nit: the ifdef'ing might be less scary if you do...

  // TODO....
#if defined(OS_CHROMEOS)
  , destroyed_(0)
#endif
  {
#if defined(OS_CHROMEOS)
  // ...
  CHECK(...
#endif

[rmcilroy, 2015-02-28 00:33:09]

https://codereview.chromium.org/962313003/diff/20001/net/sdch/sdch_owner.cc
File net/sdch/sdch_owner.cc (right):

https://codereview.chromium.org/962313003/diff/20001/net/sdch/sdch_owner.cc#n...
net/sdch/sdch_owner.cc:100: #endif
On 2015/02/28 00:18:18, David Benjamin wrote:
> Nit: the ifdef'ing might be less scary if you do...
> 
>   // TODO....
> #if defined(OS_CHROMEOS)
>   , destroyed_(0)
> #endif
>   {
> #if defined(OS_CHROMEOS)
>   // ...
>   CHECK(...
> #endif

Done.

[rmcilroy, 2015-02-28 00:33:51]

The CQ bit was checked by rmcilroy@chromium.org

[rmcilroy, 2015-02-28 00:33:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
davidben@chromium.org
Link to the patchset: https://codereview.chromium.org/962313003/#ps40001 (title:
"Change #ifdef")

[commit-bot: I haz the power, 2015-02-28 00:34:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/962313003/40001

[commit-bot: I haz the power, 2015-02-28 02:24:42]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-28 02:25:27]

Patchset 3 (id:??) landed as
https://crrev.com/9ead5677d87d725b68971f0464a423e7af22634c
Cr-Commit-Position: refs/heads/master@{#318575}