[net]: Disable SdchOwner's MemoryPressureListener to investigate http://crbug.com/447208.

net/sdch/sdch_owner.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/sdch/sdch_owner.h"
 
 #include "base/bind.h"
 #include "base/debug/alias.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/strings/string_util.h"
@@ skipping 69 matching lines @@
     : manager_(sdch_manager),
       fetcher_(context,
                base::Bind(&SdchOwner::OnDictionaryFetched,
                           // Because |fetcher_| is owned by SdchOwner, the
                           // SdchOwner object will be available for the lifetime
                           // of |fetcher_|.
                           base::Unretained(this))),
       total_dictionary_bytes_(0),
       clock_(new base::DefaultClock),
       max_total_dictionary_size_(kMaxTotalDictionarySize),
-      min_space_for_dictionary_fetch_(kMinSpaceForDictionaryFetch),
-#if defined(OS_CHROMEOS)
+      min_space_for_dictionary_fetch_(kMinSpaceForDictionaryFetch)
+      // TODO(rmcilroy) Add back memory_pressure_listener_ when
+      // http://crbug.com/447208 is fixed
+#if !defined(OS_CHROMEOS)
+      {
+#else
       // For debugging http://crbug.com/454198; remove when resolved.
-      destroyed_(0),
-#endif
-      memory_pressure_listener_(
-          base::Bind(&SdchOwner::OnMemoryPressure,
-                     // Because |memory_pressure_listener_| is owned by
-                     // SdchOwner, the SdchOwner object will be available
-                     // for the lifetime of |memory_pressure_listener_|.
-                     base::Unretained(this))) {
-#if defined(OS_CHROMEOS)
+      , destroyed_(0) {
   // For debugging http://crbug.com/454198; remove when resolved.
   CHECK(clock_.get());
 #endif

[davidben, 2015/02/28 00:18:18]

Nit: the ifdef'ing might be less scary if you do...

  // TODO....
#if defined(OS_CHROMEOS)
  , destroyed_(0)
#endif
  {
#if defined(OS_CHROMEOS)
  // ...
  CHECK(...
#endif

[rmcilroy, 2015/02/28 00:33:09]

Done.

   manager_->AddObserver(this);
 }
 
 SdchOwner::~SdchOwner() {
 #if defined(OS_CHROMEOS)
   // For debugging http://crbug.com/454198; remove when resolved.
   CHECK_EQ(0u, destroyed_);
   CHECK(clock_.get());
   clock_.reset();
 #endif
@@ skipping 197 matching lines @@
     RecordDictionaryEviction(it->second.use_count,
                              DICTIONARY_FATE_EVICT_FOR_MEMORY);
   }
 
   // TODO(rdsmith): Make a distinction between moderate and critical
   // memory pressure.
   manager_->ClearData();
 }
 
 }  // namespace net