[net]: Disable SdchOwner's MemoryPressureListener to investigate http://crbug.com/447208.

net/sdch/sdch_owner.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/sdch/sdch_owner.h"
 
 #include "base/bind.h"
 #include "base/debug/alias.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/strings/string_util.h"
@@ skipping 74 matching lines @@
                           // of |fetcher_|.
                           base::Unretained(this))),
       total_dictionary_bytes_(0),
       clock_(new base::DefaultClock),
       max_total_dictionary_size_(kMaxTotalDictionarySize),
       min_space_for_dictionary_fetch_(kMinSpaceForDictionaryFetch),
 #if defined(OS_CHROMEOS)
       // For debugging http://crbug.com/454198; remove when resolved.
       destroyed_(0),
 #endif
-      memory_pressure_listener_(
+#if 0
+      // Remove memory_pressure_listener_ to investigate http://crbug.com/447208
+      memory_pressure_listener_(new base::MemoryPressureListener(
           base::Bind(&SdchOwner::OnMemoryPressure,
-                     // Because |memory_pressure_listener_| is owned by
-                     // SdchOwner, the SdchOwner object will be available
-                     // for the lifetime of |memory_pressure_listener_|.
-                     base::Unretained(this))) {
+                         // Because |memory_pressure_listener_| is owned by
+                         // SdchOwner, the SdchOwner object will be available
+                         // for the lifetime of |memory_pressure_listener_|.
+                         base::Unretained(this)))) {
+#else
+      memory_pressure_listener_(nullptr) {
+#endif

[davidben, 2015/02/27 23:29:34]

Since we'd presumably flip this back from a scoped_ptr anyway if we were to undo
this, let's just remove these lines (and the member) and leave a TODO comment
rather than play games with #if 0. We've got version control for a reason.

 #if defined(OS_CHROMEOS)
   // For debugging http://crbug.com/454198; remove when resolved.
   CHECK(clock_.get());
 #endif
   manager_->AddObserver(this);
 }
 
 SdchOwner::~SdchOwner() {
 #if defined(OS_CHROMEOS)
   // For debugging http://crbug.com/454198; remove when resolved.
@@ skipping 201 matching lines @@
     RecordDictionaryEviction(it->second.use_count,
                              DICTIONARY_FATE_EVICT_FOR_MEMORY);
   }
 
   // TODO(rdsmith): Make a distinction between moderate and critical
   // memory pressure.
   manager_->ClearData();
 }
 
 }  // namespace net