Issue 961613002: Make ChromeBookmarkClient::CanSetPermanentNodeTitle say true for the supervised node.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 961613002: Make ChromeBookmarkClient::CanSetPermanentNodeTitle say true for the supervised node. (Closed)

Created:
5 years, 9 months ago by Marc Treib

Modified:
5 years, 9 months ago

Reviewers:
amineer

CC:
chromium-reviews, tfarina, noyau+watch_chromium.org, browser-components-watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2311

Target Ref:
refs/pending/branch-heads/2311

Project:
chromium

Visibility:
Public.

Make ChromeBookmarkClient::CanSetPermanentNodeTitle say true for the supervised node. The title can actually change when switching to a different translation, which would trigger a NOTREACHED in BookmarkModel::SetTitle. BUG=459448 Review URL: https://codereview.chromium.org/946363002 Cr-Commit-Position: refs/heads/master@{#317587} (cherry picked from commit 2d81cac8f27f6b05c77757e3f1959b29d9d39875) TBR=amineer Committed: https://chromium.googlesource.com/chromium/src/+/873db69ca7d50ab357ecb0b938c5646cb5124cd4

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	chrome/browser/bookmarks/chrome_bookmark_client.cc	View		1 chunk	+5 lines, -3 lines	0 comments	Download

Total messages: 2 (1 generated)

Marc Treib

5 years, 9 months ago (2015-02-26 09:36:47 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
873db69ca7d50ab357ecb0b938c5646cb5124cd4 (presubmit successful).