Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Unified Diff: chrome/browser/bookmarks/chrome_bookmark_client.cc

Issue 961613002: Make ChromeBookmarkClient::CanSetPermanentNodeTitle say true for the supervised node. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2311
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/bookmarks/chrome_bookmark_client.cc
diff --git a/chrome/browser/bookmarks/chrome_bookmark_client.cc b/chrome/browser/bookmarks/chrome_bookmark_client.cc
index 15d835dfab200beeea3eedbb97b5f15cb477295c..7b82935beff1e4df4380c7e46ecf28a80e9337ba 100644
--- a/chrome/browser/bookmarks/chrome_bookmark_client.cc
+++ b/chrome/browser/bookmarks/chrome_bookmark_client.cc
@@ -196,11 +196,13 @@ bookmarks::LoadExtraCallback ChromeBookmarkClient::GetLoadExtraNodesCallback() {
bool ChromeBookmarkClient::CanSetPermanentNodeTitle(
const BookmarkNode* permanent_node) {
// The |managed_node_| can have its title updated if the user signs in or
- // out, since the name of the managed domain can appear in it. The
- // |supervised_node_| has a fixed title which can never be updated.
+ // out, since the name of the managed domain can appear in it.
+ // Also, both |managed_node_| and |supervised_node_| can have their title
+ // updated on locale changes (crbug.com/459448).
return (!bookmarks::IsDescendantOf(permanent_node, managed_node_) &&
!bookmarks::IsDescendantOf(permanent_node, supervised_node_)) ||
- permanent_node == managed_node_;
+ permanent_node == managed_node_ ||
+ permanent_node == supervised_node_;
}
bool ChromeBookmarkClient::CanSyncNode(const BookmarkNode* node) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698