Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 946363002: Make ChromeBookmarkClient::CanSetPermanentNodeTitle say true for the supervised node. (Closed)

Created:
5 years, 10 months ago by Marc Treib
Modified:
5 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org, browser-components-watch_chromium.org, msw, amineer, Alexander Alekseev
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make ChromeBookmarkClient::CanSetPermanentNodeTitle say true for the supervised node. The title can actually change when switching to a different translation, which would trigger a NOTREACHED in BookmarkModel::SetTitle. BUG=459448 Committed: https://crrev.com/2d81cac8f27f6b05c77757e3f1959b29d9d39875 Cr-Commit-Position: refs/heads/master@{#317587}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M chrome/browser/bookmarks/chrome_bookmark_client.cc View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Marc Treib
PTAL! I've verified locally that this fixes the failing tests (see linked bug) even with ...
5 years, 10 months ago (2015-02-23 12:09:40 UTC) #2
sky
LGTM
5 years, 10 months ago (2015-02-23 15:53:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/946363002/1
5 years, 10 months ago (2015-02-23 15:54:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-23 15:57:10 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 15:57:53 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2d81cac8f27f6b05c77757e3f1959b29d9d39875
Cr-Commit-Position: refs/heads/master@{#317587}

Powered by Google App Engine
This is Rietveld 408576698