Make perf try jobs for win x64 build x64 binaries.

Make perf try jobs for win x64 build x64 binaries.

Perf try jobs running on Win x64 bisect bots should build and run tests on x64 binaries.

BUG=462639
Committed: https://crrev.com/b3002837d27fe6ed516e8e6912e75ebfbe08b562
Cr-Commit-Position: refs/heads/master@{#318570}

[prasadv, 2015-02-27 00:49:30]

prasadv@chromium.org changed reviewers:
+ prasadv@chromium.org, qyearsley@chromium.org, sullivan@chromium.org

[prasadv, 2015-02-27 00:49:31]

Lately I noticed that the perf try jobs for Win x64 are producing 32 bit
binaries instead of x64. I assume "target_arch" is the parameter that determines
this. Since the builds are produced locally on the bisect bots we need to make
sure that perf try job are run appropriate binary.
Note: Bisect on revision ranges should still be working fine without this change
since the builds are downloaded from archive and they are produced by x64
builders.

[prasadv, 2015-02-27 00:49:50]

prasadv@chromium.org changed reviewers:
+ stip@chromium.org

[prasadv, 2015-02-27 00:49:51]

+Mike

[qyearsley, 2015-02-27 03:37:57]

I didn't spot any problems in the changes in auto_bisect/; remember to wait for
successful try jobs with different sample configs (including a win x64 local
build config, which you could add to auto_bisect/configs).

https://codereview.chromium.org/961193002/diff/1/tools/auto_bisect/bisect_per...
File tools/auto_bisect/bisect_perf_regression.py (right):

https://codereview.chromium.org/961193002/diff/1/tools/auto_bisect/bisect_per...
tools/auto_bisect/bisect_perf_regression.py:1184: print '%s: %s' % (key, value)
A possible alternative to using print would be using logging.info -- that's used
to output most info during execution. By default, _ConfigureLogging() below is
run, and logging.info also just prints to stdout.

https://codereview.chromium.org/961193002/diff/1/tools/auto_bisect/builder.py
File tools/auto_bisect/builder.py (right):

https://codereview.chromium.org/961193002/diff/1/tools/auto_bisect/builder.py...
tools/auto_bisect/builder.py:203: target_arch: The target build architecture
ia32 or x64. Default is ia32
Style nit: Missing period at the end; I think you should also add a comma or
colon before 'ia32 or x64".

[prasadv, 2015-02-27 18:08:16]

https://codereview.chromium.org/961193002/diff/1/tools/auto_bisect/bisect_per...
File tools/auto_bisect/bisect_perf_regression.py (right):

https://codereview.chromium.org/961193002/diff/1/tools/auto_bisect/bisect_per...
tools/auto_bisect/bisect_perf_regression.py:1184: print '%s: %s' % (key, value)
On 2015/02/27 03:37:57, qyearsley wrote:
> A possible alternative to using print would be using logging.info -- that's
used
> to output most info during execution. By default, _ConfigureLogging() below is
> run, and logging.info also just prints to stdout.

I tried using logging but output was delayed till the compile was finished. Here
we want to display cenvironment before we start compile step.

https://codereview.chromium.org/961193002/diff/1/tools/auto_bisect/builder.py
File tools/auto_bisect/builder.py (right):

https://codereview.chromium.org/961193002/diff/1/tools/auto_bisect/builder.py...
tools/auto_bisect/builder.py:203: target_arch: The target build architecture
ia32 or x64. Default is ia32
On 2015/02/27 03:37:57, qyearsley wrote:
> Style nit: Missing period at the end; I think you should also add a comma or
> colon before 'ia32 or x64". 

Done.

[qyearsley, 2015-02-27 19:41:10]

lgtm

https://codereview.chromium.org/961193002/diff/20001/tools/auto_bisect/bisect...
File tools/auto_bisect/bisect_perf_regression.py (right):

https://codereview.chromium.org/961193002/diff/20001/tools/auto_bisect/bisect...
tools/auto_bisect/bisect_perf_regression.py:2643: choices=['Release', 'Debug'],
Remember to update this option here as well as you mentioned.

https://codereview.chromium.org/961193002/diff/20001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py
(right):

https://codereview.chromium.org/961193002/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py:155: def
_AttemptTryjob(self, cfg_file_path):
Besides refactoring _AttemptTryjob and adding target_arch to the config and
adding --browser=release_x64 to the Telemetry command if x64 is in the bot name,
are there other changes in this file?

https://codereview.chromium.org/961193002/diff/20001/tools/telemetry/telemetr...
File
tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder_unittest.py
(right):

https://codereview.chromium.org/961193002/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder_unittest.py:228:
def test_config_winx_64(self):
Should this be test_config_win_x64 or test_config_winx64?

[qyearsley, 2015-02-27 19:52:14]

Note, Should wait for review by others first.

Also, now I think that the changes to trybot_browser_finder.py and auto-bisect
could have been split into separate CLs.

[sullivan, 2015-02-27 22:30:25]

https://codereview.chromium.org/961193002/diff/40001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py
(right):

https://codereview.chromium.org/961193002/diff/40001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py:191:
ret_value, output = self._UploadPatchAndTry()
Can you split the refactoring into a follow-up CL? That way the functional
changes are easire to track.

[sullivan, 2015-02-27 22:56:12]

lgtm

lgtm after answering question about always setting target_arch

https://codereview.chromium.org/961193002/diff/80001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py
(right):

https://codereview.chromium.org/961193002/diff/80001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py:127:
target_arch = 'x64' if 'x64' in self._buildername else 'ia32'
Should this always be set? i.e. for Android builds?

[prasadv, 2015-02-27 23:01:15]

https://codereview.chromium.org/961193002/diff/20001/tools/auto_bisect/bisect...
File tools/auto_bisect/bisect_perf_regression.py (right):

https://codereview.chromium.org/961193002/diff/20001/tools/auto_bisect/bisect...
tools/auto_bisect/bisect_perf_regression.py:2643: choices=['Release', 'Debug'],
On 2015/02/27 19:41:09, qyearsley wrote:
> Remember to update this option here as well as you mentioned.

Done.

https://codereview.chromium.org/961193002/diff/20001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py
(right):

https://codereview.chromium.org/961193002/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py:155: def
_AttemptTryjob(self, cfg_file_path):
On 2015/02/27 19:41:09, qyearsley wrote:
> Besides refactoring _AttemptTryjob and adding target_arch to the config and
> adding --browser=release_x64 to the Telemetry command if x64 is in the bot
name,
> are there other changes in this file?

Nope!

https://codereview.chromium.org/961193002/diff/20001/tools/telemetry/telemetr...
File
tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder_unittest.py
(right):

https://codereview.chromium.org/961193002/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder_unittest.py:228:
def test_config_winx_64(self):
On 2015/02/27 19:41:09, qyearsley wrote:
> Should this be test_config_win_x64 or test_config_winx64?

Done.

https://codereview.chromium.org/961193002/diff/80001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py
(right):

https://codereview.chromium.org/961193002/diff/80001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py:127:
target_arch = 'x64' if 'x64' in self._buildername else 'ia32'
On 2015/02/27 22:56:12, sullivan wrote:
> Should this always be set? i.e. for Android builds?

Yes, even if we don't set this values here, in bisect script target_arch is by
default set to 'ia32'.

[prasadv, 2015-02-28 00:22:37]

The CQ bit was checked by prasadv@chromium.org

[prasadv, 2015-02-28 00:22:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
qyearsley@chromium.org, sullivan@chromium.org
Link to the patchset: https://codereview.chromium.org/961193002/#ps100001
(title: " ")

[commit-bot: I haz the power, 2015-02-28 00:23:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/961193002/100001

[commit-bot: I haz the power, 2015-02-28 02:00:03]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-02-28 02:00:48]

Patchset 6 (id:??) landed as
https://crrev.com/b3002837d27fe6ed516e8e6912e75ebfbe08b562
Cr-Commit-Position: refs/heads/master@{#318570}