tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py - Issue 961193002: Make perf try jobs for win x64 build x64 binaries.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py

Issue 961193002: Make perf try jobs for win x64 build x64 binaries. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/auto_bisect/configs/winx64.perf_test.kraken.cfg ('k') | tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py

diff --git a/tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py b/tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py

index ea7143ca5b0ca9b10a14349d407aea227612221c..344d1bf5015003bee750cd3808e16d4dde209e3c 100644

--- a/tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py

+++ b/tools/telemetry/telemetry/core/backends/remote/trybot_browser_finder.py

@@ -117,16 +117,22 @@ class PossibleTrybotBrowser(possible_browser.PossibleBrowser):

if arg.startswith('--browser='):

if self._target_os == 'android':

arguments[index] = '--browser=android-chrome-shell'

+ elif 'x64' in self._buildername:

+ arguments[index] = '--browser=release_x64'

else:

arguments[index] = '--browser=release'

command = ' '.join(arguments)

+ # Set target architecture to build 32 or 64 bit binaries.

+ target_arch = 'x64' if 'x64' in self._buildername else 'ia32'

# Add the correct command to the config file and commit it.

config = {

'command': command,

'repeat_count': '1',

'max_time_minutes': '120',

'truncate_percent': '0',

+ 'target_arch': target_arch,

}

try:

config_file = open(cfg_file_path, 'w')