Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: tools/auto_bisect/bisect_perf_regression.py

Issue 961193002: Make perf try jobs for win x64 build x64 binaries. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/auto_bisect/builder.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/auto_bisect/bisect_perf_regression.py
diff --git a/tools/auto_bisect/bisect_perf_regression.py b/tools/auto_bisect/bisect_perf_regression.py
index 62f9cb27d9e85c02020b9b5315f69e6c85b1232d..71f701c9a6e74ea5f90212f281f4e6962e687c73 100755
--- a/tools/auto_bisect/bisect_perf_regression.py
+++ b/tools/auto_bisect/bisect_perf_regression.py
@@ -1178,7 +1178,12 @@ class BisectPerformanceMetrics(object):
build_success = self._DownloadAndUnzipBuild(
revision, depot, build_type='Release', create_patch=create_patch)
else:
- # Build locally.
+ # Print the current environment set on the machine.
+ print 'Full Environment:'
+ for key, value in sorted(os.environ.items()):
+ print '%s: %s' % (key, value)
+ # Print the environment before proceeding with compile.
+ sys.stdout.flush()
build_success = self.builder.Build(depot, self.opts)
os.chdir(cwd)
return build_success
@@ -2635,9 +2640,9 @@ class BisectOptions(object):
help='The target build architecture. Choices are "ia32" '
'(default), "x64" or "arm".')
group.add_argument('--target_build_type', default='Release',
- choices=['Release', 'Debug'],
+ choices=['Release', 'Debug', 'Release_x64'],
help='The target build type. Choices are "Release" '
- '(default), or "Debug".')
+ '(default), Release_x64 or "Debug".')
group.add_argument('--builder_type', default=fetch_build.PERF_BUILDER,
choices=[fetch_build.PERF_BUILDER,
fetch_build.FULL_BUILDER, ''],
@@ -2731,6 +2736,8 @@ class BisectOptions(object):
raise RuntimeError('Invalid metric specified: [%s]' % opts.metric)
opts.metric = metric_values
+ if opts.target_arch == 'x64' and opts.target_build_type == 'Release':
+ opts.target_build_type = 'Release_x64'
opts.repeat_test_count = min(max(opts.repeat_test_count, 1), 100)
opts.max_time_minutes = min(max(opts.max_time_minutes, 1), 60)
opts.truncate_percent = min(max(opts.truncate_percent, 0), 25)
« no previous file with comments | « no previous file | tools/auto_bisect/builder.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698