Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 960813002: [clang] Set correct clang warning flags. (Closed)

Created:
5 years, 10 months ago by Benedikt Meurer
Modified:
5 years, 10 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[clang] Set correct clang warning flags. Import the build/set_clang_warning_flags.gypi magic from Chrome (which is used by third party .gyp files to enable/disable warnings that we/Chrome shouldn't care about). Also make sure that we don't pass certain flags as -Wall or -pedantic to third party code. This way we do no longer generate all those stupid warnings in icu. R=svenpanne@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -3 lines) Patch
A build/set_clang_warning_flags.gypi View 1 chunk +58 lines, -0 lines 0 comments Download
M build/standalone.gypi View 4 chunks +13 lines, -3 lines 0 comments Download
M build/toolchain.gypi View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Benedikt Meurer
5 years, 10 months ago (2015-02-26 07:07:59 UTC) #1
Benedikt Meurer
5 years, 10 months ago (2015-02-26 07:08:11 UTC) #2
PTAL

Powered by Google App Engine
This is Rietveld 408576698