Issue 960813002: [clang] Set correct clang warning flags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 960813002: [clang] Set correct clang warning flags. (Closed)

Created:
5 years, 10 months ago by Benedikt Meurer

Modified:
5 years, 10 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

[clang] Set correct clang warning flags. Import the build/set_clang_warning_flags.gypi magic from Chrome (which is used by third party .gyp files to enable/disable warnings that we/Chrome shouldn't care about). Also make sure that we don't pass certain flags as -Wall or -pedantic to third party code. This way we do no longer generate all those stupid warnings in icu. R=svenpanne@chromium.org

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+80 lines, -3 lines)			Patch
A	build/set_clang_warning_flags.gypi	View	1 chunk	+58 lines, -0 lines	0 comments	Download
M	build/standalone.gypi	View	4 chunks	+13 lines, -3 lines	0 comments	Download
M	build/toolchain.gypi	View	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

PTAL

Expand Messages | Collapse Messages