Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Side by Side Diff: build/toolchain.gypi

Issue 960813002: [clang] Set correct clang warning flags. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/standalone.gypi ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 the V8 project authors. All rights reserved. 1 # Copyright 2013 the V8 project authors. All rights reserved.
2 # Redistribution and use in source and binary forms, with or without 2 # Redistribution and use in source and binary forms, with or without
3 # modification, are permitted provided that the following conditions are 3 # modification, are permitted provided that the following conditions are
4 # met: 4 # met:
5 # 5 #
6 # * Redistributions of source code must retain the above copyright 6 # * Redistributions of source code must retain the above copyright
7 # notice, this list of conditions and the following disclaimer. 7 # notice, this list of conditions and the following disclaimer.
8 # * Redistributions in binary form must reproduce the above 8 # * Redistributions in binary form must reproduce the above
9 # copyright notice, this list of conditions and the following 9 # copyright notice, this list of conditions and the following
10 # disclaimer in the documentation and/or other materials provided 10 # disclaimer in the documentation and/or other materials provided
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
158 'variables': { 158 'variables': {
159 'target_cxx_is_biarch%': 1, 159 'target_cxx_is_biarch%': 1,
160 }, 160 },
161 }, { 161 }, {
162 'variables': { 162 'variables': {
163 'target_cxx_is_biarch%': 0, 163 'target_cxx_is_biarch%': 0,
164 }, 164 },
165 }], 165 }],
166 ], 166 ],
167 'target_defaults': { 167 'target_defaults': {
168 'variables': {
169 'clang_warning_flags': [
170 '-Wheader-hygiene',
171
172 # Warns when a const char[] is converted to bool.
173 '-Wstring-conversion',
174 ],
175 },
176 'includes': [ 'set_clang_warning_flags.gypi', ],
168 'conditions': [ 177 'conditions': [
169 ['v8_target_arch=="arm"', { 178 ['v8_target_arch=="arm"', {
170 'defines': [ 179 'defines': [
171 'V8_TARGET_ARCH_ARM', 180 'V8_TARGET_ARCH_ARM',
172 ], 181 ],
173 'conditions': [ 182 'conditions': [
174 [ 'arm_version==7 or arm_version=="default"', { 183 [ 'arm_version==7 or arm_version=="default"', {
175 'defines': [ 184 'defines': [
176 'CAN_USE_ARMV7_INSTRUCTIONS', 185 'CAN_USE_ARMV7_INSTRUCTIONS',
177 ], 186 ],
(...skipping 1085 matching lines...) Expand 10 before | Expand all | Expand 10 after
1263 ['v8_enable_slow_dchecks==1', { 1272 ['v8_enable_slow_dchecks==1', {
1264 'defines': [ 1273 'defines': [
1265 'ENABLE_SLOW_DCHECKS', 1274 'ENABLE_SLOW_DCHECKS',
1266 ], 1275 ],
1267 }], 1276 }],
1268 ], # conditions 1277 ], # conditions
1269 }, # Release 1278 }, # Release
1270 }, # configurations 1279 }, # configurations
1271 }, # target_defaults 1280 }, # target_defaults
1272 } 1281 }
OLDNEW
« no previous file with comments | « build/standalone.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698