Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1438)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/toolchain.gypi

Issue 960813002: [clang] Set correct clang warning flags. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/standalone.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/toolchain.gypi
diff --git a/build/toolchain.gypi b/build/toolchain.gypi
index b8c73177853fa4ac988b8394dbfc633b272d557f..d8cb5f76108e3b8422c307cfc471050daa0db95a 100644
--- a/build/toolchain.gypi
+++ b/build/toolchain.gypi
@@ -165,6 +165,15 @@
}],
],
'target_defaults': {
+ 'variables': {
+ 'clang_warning_flags': [
+ '-Wheader-hygiene',
+
+ # Warns when a const char[] is converted to bool.
+ '-Wstring-conversion',
+ ],
+ },
+ 'includes': [ 'set_clang_warning_flags.gypi', ],
'conditions': [
['v8_target_arch=="arm"', {
'defines': [
« no previous file with comments | « build/standalone.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698