Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 960203002: Automatically add a docs preview link and NOTRY=true when there are only docs changes (Closed)

Created:
4 years, 2 months ago by rmistry
Modified:
4 years, 2 months ago
Reviewers:
jcgregorio, borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Automatically add a docs preview link and NOTRY=true when there are only docs changes. These changes are possible due to the recently submitted depot_tools change https://codereview.chromium.org/949273002/ ('Add ability to specify and run post upload hooks'). BUG=skia:3474 Committed: https://skia.googlesource.com/skia/+/d223fb21d61b371619b442e95a8de3a3de21b607

Patch Set 1 : Initial upload #

Total comments: 2

Patch Set 2 : Short circuit the loop #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -0 lines) Patch
M PRESUBMIT.py View 1 3 chunks +58 lines, -0 lines 0 comments Download
M codereview.settings View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
rmistry
4 years, 2 months ago (2015-02-26 14:15:52 UTC) #2
rmistry
4 years, 2 months ago (2015-02-26 16:40:23 UTC) #4
jcgregorio
On 2015/02/26 16:40:23, rmistry wrote: Why only when the changes are only docs changes. Can't ...
4 years, 2 months ago (2015-02-26 16:46:21 UTC) #5
rmistry
On 2015/02/26 16:46:21, jcgregorio wrote: > On 2015/02/26 16:40:23, rmistry wrote: > > Why only ...
4 years, 2 months ago (2015-02-26 16:50:02 UTC) #6
jcgregorio
On 2015/02/26 16:50:02, rmistry wrote: > On 2015/02/26 16:46:21, jcgregorio wrote: > > On 2015/02/26 ...
4 years, 2 months ago (2015-02-26 17:06:26 UTC) #7
rmistry
On 2015/02/26 17:06:26, jcgregorio wrote: > On 2015/02/26 16:50:02, rmistry wrote: > > On 2015/02/26 ...
4 years, 2 months ago (2015-02-26 17:10:27 UTC) #8
borenet
LGTM. Now PRESUBMIT.py seems to be the wrong name :) https://codereview.chromium.org/960203002/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/960203002/diff/1/PRESUBMIT.py#newcode262 ...
4 years, 2 months ago (2015-02-26 17:38:56 UTC) #9
rmistry
https://codereview.chromium.org/960203002/diff/1/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/960203002/diff/1/PRESUBMIT.py#newcode262 PRESUBMIT.py:262: all_docs_changes = False On 2015/02/26 17:38:56, borenet wrote: > ...
4 years, 2 months ago (2015-02-26 18:09:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/960203002/20001
4 years, 2 months ago (2015-02-26 18:10:19 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2015-02-26 18:16:17 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/d223fb21d61b371619b442e95a8de3a3de21b607

Powered by Google App Engine
This is Rietveld 408576698