Automatically add a docs preview link and NOTRY=true when there are only docs changes

Automatically add a docs preview link and NOTRY=true when there are only docs changes.

These changes are possible due to the recently submitted depot_tools change
https://codereview.chromium.org/949273002/ ('Add ability to specify and run post upload hooks').

BUG=skia:3474
Committed: https://skia.googlesource.com/skia/+/d223fb21d61b371619b442e95a8de3a3de21b607

[rmistry, 2015-02-26 14:15:51]

rmistry@google.com changed reviewers:
+ jcgregorio@google.com

[rmistry, 2015-02-26 16:40:22]

rmistry@google.com changed reviewers:
+ borenet@google.com

[jcgregorio, 2015-02-26 16:46:21]

On 2015/02/26 16:40:23, rmistry wrote:

Why only when the changes are only docs changes. Can't we send it if any file
changes a doc? The link would still be useful, and I'd like to encourage
changing docs and code at the same time it if makes sense.

[rmistry, 2015-02-26 16:50:02]

On 2015/02/26 16:46:21, jcgregorio wrote:
> On 2015/02/26 16:40:23, rmistry wrote:
> 
> Why only when the changes are only docs changes. Can't we send it if any file
> changes a doc? The link would still be useful, and I'd like to encourage
> changing docs and code at the same time it if makes sense.

Not sure I understand. How would this detect if any file changes a doc other
than if a change is made in the sites directory?

[jcgregorio, 2015-02-26 17:06:26]

On 2015/02/26 16:50:02, rmistry wrote:
> On 2015/02/26 16:46:21, jcgregorio wrote:
> > On 2015/02/26 16:40:23, rmistry wrote:
> > 
> > Why only when the changes are only docs changes. Can't we send it if any
file
> > changes a doc? The link would still be useful, and I'd like to encourage
> > changing docs and code at the same time it if makes sense.
> 
> Not sure I understand. How would this detect if any file changes a doc other
> than if a change is made in the sites directory?

Sorry, my bad, I misread the code. LGTM

[rmistry, 2015-02-26 17:10:27]

On 2015/02/26 17:06:26, jcgregorio wrote:
> On 2015/02/26 16:50:02, rmistry wrote:
> > On 2015/02/26 16:46:21, jcgregorio wrote:
> > > On 2015/02/26 16:40:23, rmistry wrote:
> > > 
> > > Why only when the changes are only docs changes. Can't we send it if any
> file
> > > changes a doc? The link would still be useful, and I'd like to encourage
> > > changing docs and code at the same time it if makes sense.
> > 
> > Not sure I understand. How would this detect if any file changes a doc other
> > than if a change is made in the sites directory?
> 
> Sorry, my bad, I misread the code. LGTM

Ah k, I was worried I completely misunderstood the requirements :)

[borenet, 2015-02-26 17:38:56]

LGTM.  Now PRESUBMIT.py seems to be the wrong name :)

https://codereview.chromium.org/960203002/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/960203002/diff/1/PRESUBMIT.py#newcode262
PRESUBMIT.py:262: all_docs_changes = False
Nit: you could short-cut here to avoid having to loop through all files:

if at_least_one_docs_change and not all_docs_changes:
  break

[rmistry, 2015-02-26 18:09:39]

https://codereview.chromium.org/960203002/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/960203002/diff/1/PRESUBMIT.py#newcode262
PRESUBMIT.py:262: all_docs_changes = False
On 2015/02/26 17:38:56, borenet wrote:
> Nit: you could short-cut here to avoid having to loop through all files:
> 
> if at_least_one_docs_change and not all_docs_changes:
>   break

Done.

[rmistry, 2015-02-26 18:10:09]

The CQ bit was checked by rmistry@google.com

[rmistry, 2015-02-26 18:10:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
jcgregorio@google.com, borenet@google.com
Link to the patchset: https://codereview.chromium.org/960203002/#ps20001 (title:
"Short circuit the loop")

[commit-bot: I haz the power, 2015-02-26 18:10:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/960203002/20001

[commit-bot: I haz the power, 2015-02-26 18:16:17]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/d223fb21d61b371619b442e95a8de3a3de21b607