Log sending HTTP/2 HEADERS frames correctly.

Log sending HTTP/2 HEADERS frames correctly.

This CL changes the event type logged when HTTP/2 HEADERS frame is sent to
reflect that fact that it is not a SYN_STREAM (which does not even exist in
HTTP2).

BUG=456986
Committed: https://crrev.com/a25d7e09c74505a08160143dcd5b2e9d6b88874e
Cr-Commit-Position: refs/heads/master@{#318249}

[Bence, 2015-02-25 20:41:46]

bnc@chromium.org changed reviewers:
+ mmenke@chromium.org

[Bence, 2015-02-25 20:41:47]

Matt: PTAL.  Thanks.

Ilya: FYI this is the change I promised in https://crrev.com/934823005#msg4.

[mmenke, 2015-02-25 21:04:46]

On 2015/02/25 20:41:47, Bence wrote:
> Matt: PTAL.  Thanks.
> 
> Ilya: FYI this is the change I promised in https://crrev.com/934823005#msg4.

Looks like some tests were checking the NetLog event in this case.

[mmenke, 2015-02-25 21:04:46]

On 2015/02/25 20:41:47, Bence wrote:
> Matt: PTAL.  Thanks.
> 
> Ilya: FYI this is the change I promised in https://crrev.com/934823005#msg4.

Looks like some tests were checking the NetLog event in this case.

[Bence, 2015-02-26 12:23:52]

Matt: I'm sorry about that.  Please take another look.  Thanks.

On 2015/02/25 21:04:46, mmenke wrote:
> On 2015/02/25 20:41:47, Bence wrote:
> > Matt: PTAL.  Thanks.
> > 
> > Ilya: FYI this is the change I promised in https://crrev.com/934823005#msg4.
> 
> Looks like some tests were checking the NetLog event in this case.

[mmenke, 2015-02-26 16:04:20]

LGTM

https://codereview.chromium.org/959903002/diff/20001/net/spdy/spdy_network_tr...
File net/spdy/spdy_network_transaction_unittest.cc (right):

https://codereview.chromium.org/959903002/diff/20001/net/spdy/spdy_network_tr...
net/spdy/spdy_network_transaction_unittest.cc:3782: const NetLog::EventType type
=
optional nit:  const generally isn't used for things that aren't build time
constants or constant class variables.

https://codereview.chromium.org/959903002/diff/20001/net/spdy/spdy_session.cc
File net/spdy/spdy_session.cc (right):

https://codereview.chromium.org/959903002/diff/20001/net/spdy/spdy_session.cc...
net/spdy/spdy_session.cc:1089: : NetLog::TYPE_HTTP2_SESSION_SEND_HEADERS;
optional nit:  const generally isn't used for things that aren't build time
constants or constant class variables.

[Bence, 2015-02-26 16:37:12]

The CQ bit was checked by bnc@chromium.org

[commit-bot: I haz the power, 2015-02-26 16:38:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/959903002/20001

[commit-bot: I haz the power, 2015-02-26 16:51:59]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-26 16:53:02]

Patchset 2 (id:??) landed as
https://crrev.com/a25d7e09c74505a08160143dcd5b2e9d6b88874e
Cr-Commit-Position: refs/heads/master@{#318249}