net/spdy/spdy_session.cc - Issue 959903002: Log sending HTTP/2 HEADERS frames correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_session.cc

Issue 959903002: Log sending HTTP/2 HEADERS frames correctly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Modify test. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/spdy/spdy_session.cc

diff --git a/net/spdy/spdy_session.cc b/net/spdy/spdy_session.cc

index b6318e00454b11b8c2b4f8b847cd0705c22e36b9..a5a1ea6298d7f343aaaf78fc9951ee6b5854069e 100644

--- a/net/spdy/spdy_session.cc

+++ b/net/spdy/spdy_session.cc

@@ -1083,7 +1083,11 @@ scoped_ptr<SpdyFrame> SpdySession::CreateSynStream(

streams_initiated_count_++;

if (net_log().IsLogging()) {

- net_log().AddEvent(NetLog::TYPE_HTTP2_SESSION_SYN_STREAM,

+ const NetLog::EventType type =

+ (GetProtocolVersion() <= SPDY3)

+ ? NetLog::TYPE_HTTP2_SESSION_SYN_STREAM

+ : NetLog::TYPE_HTTP2_SESSION_SEND_HEADERS;

mmenke 2015/02/26 16:04:20 optional nit: const generally isn't used for thin

+ net_log().AddEvent(type,

base::Bind(&NetLogSpdySynStreamSentCallback, &block,

(flags & CONTROL_FLAG_FIN) != 0,

(flags & CONTROL_FLAG_UNIDIRECTIONAL) != 0,