Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Unified Diff: net/spdy/spdy_network_transaction_unittest.cc

Issue 959903002: Log sending HTTP/2 HEADERS frames correctly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Modify test. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/spdy/spdy_session.cc » ('j') | net/spdy/spdy_session.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_network_transaction_unittest.cc
diff --git a/net/spdy/spdy_network_transaction_unittest.cc b/net/spdy/spdy_network_transaction_unittest.cc
index 83f6bc0cf194fbe76656a795e4c86a3930d188d2..a79d76a8bfeda79de4db1cc1d6eda1dfa4ec46c8 100644
--- a/net/spdy/spdy_network_transaction_unittest.cc
+++ b/net/spdy/spdy_network_transaction_unittest.cc
@@ -3779,9 +3779,12 @@ TEST_P(SpdyNetworkTransactionTest, NetLog) {
net::NetLog::PHASE_END);
// Check that we logged all the headers correctly
- pos = net::ExpectLogContainsSomewhere(
- entries, 0, net::NetLog::TYPE_HTTP2_SESSION_SYN_STREAM,
- net::NetLog::PHASE_NONE);
+ const NetLog::EventType type =
mmenke 2015/02/26 16:04:19 optional nit: const generally isn't used for thin
+ (GetParam().protocol <= kProtoSPDY31)
+ ? net::NetLog::TYPE_HTTP2_SESSION_SYN_STREAM
+ : net::NetLog::TYPE_HTTP2_SESSION_SEND_HEADERS;
+ pos = net::ExpectLogContainsSomewhere(entries, 0, type,
+ net::NetLog::PHASE_NONE);
base::ListValue* header_list;
ASSERT_TRUE(entries[pos].params.get());
« no previous file with comments | « no previous file | net/spdy/spdy_session.cc » ('j') | net/spdy/spdy_session.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698