Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 959643002: Remove the overflowchanged event with a runtime flag (Closed)

Created:
5 years, 10 months ago by philipj_slow
Modified:
5 years, 10 months ago
Reviewers:
chrishtr
CC:
arv+blink, blink-reviews, blink-reviews-dom_chromium.org, Inactive, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, vivekg_samsung, vivekg
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove the overflowchanged event with a runtime flag Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/NZ7RGtrPQsw/DRQmRzSkGNAJ A full removal touches many files, so keep it behind a flag in case this needs to be reverted. The tests are much less prone to conflicts, so in order to avoid creating a virtual testsuite, simply remove them. They can be restored if necessary later. All but one of the removed tests are explictly for some aspect of the overflowchanged event. The exception is layout-overflow-not-affected-by-visual-overflow.html which is from the fix of "RenderBox layout overflow is not correctly computed": https://code.google.com/p/chromium/issues/detail?id=254002 Unfortunately, it does not appear that the bug has any other observable effect that can be used. An old version of Chromium with the bug was tested; the rendered result is identical and overflow:scroll does not cause any scrollbars to appear. Therefore, the test is removed. BUG=460822 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190938

Patch Set 1 #

Patch Set 2 : tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -520 lines) Patch
M LayoutTests/fast/dom/Window/resources/window-properties.js View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/Window/window-lookup-precedence-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/wrapper-classes.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/wrapper-classes-expected.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/fast/events/change-overflow-on-overflow-change.html View 1 1 chunk +0 lines, -67 lines 0 comments Download
D LayoutTests/fast/events/change-overflow-on-overflow-change-expected.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/fast/events/constructors/overflow-event-constructor.html View 1 1 chunk +0 lines, -65 lines 0 comments Download
D LayoutTests/fast/events/constructors/overflow-event-constructor-expected.txt View 1 1 chunk +0 lines, -49 lines 0 comments Download
M LayoutTests/fast/events/event-creation.html View 1 1 chunk +0 lines, -5 lines 0 comments Download
M LayoutTests/fast/events/event-creation-expected.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/fast/events/overflow-events.html View 1 1 chunk +0 lines, -84 lines 0 comments Download
D LayoutTests/fast/events/overflow-events-expected.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/fast/events/overflow-events-writing-mode.html View 1 1 chunk +0 lines, -90 lines 0 comments Download
D LayoutTests/fast/events/overflow-events-writing-mode-expected.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/fast/events/overflow-viewport-renderer-deleted.html View 1 1 chunk +0 lines, -26 lines 0 comments Download
D LayoutTests/fast/events/overflow-viewport-renderer-deleted-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/fast/events/overflowchanged-event-raf-timing.html View 1 1 chunk +0 lines, -55 lines 0 comments Download
D LayoutTests/fast/events/overflowchanged-event-raf-timing-expected.txt View 1 1 chunk +0 lines, -10 lines 0 comments Download
M LayoutTests/fast/js/constructor-length.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/js/constructor-length-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/fast/overflow/layout-overflow-not-affected-by-visual-overflow.html View 1 1 chunk +0 lines, -27 lines 0 comments Download
D LayoutTests/fast/overflow/layout-overflow-not-affected-by-visual-overflow-expected.txt View 1 1 chunk +0 lines, -6 lines 0 comments Download
M LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 1 chunk +0 lines, -5 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/OverflowEvent.cpp View 4 chunks +6 lines, -0 lines 0 comments Download
M Source/core/events/OverflowEvent.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/events/OverflowEventInit.idl View 1 chunk +3 lines, -1 line 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
philipj_slow
tests
5 years, 10 months ago (2015-02-26 11:41:15 UTC) #1
philipj_slow
PTAL
5 years, 10 months ago (2015-02-26 13:52:00 UTC) #3
chrishtr
lgtm
5 years, 10 months ago (2015-02-26 17:45:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/959643002/20001
5 years, 10 months ago (2015-02-26 17:45:23 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 17:49:08 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190938

Powered by Google App Engine
This is Rietveld 408576698