Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Side by Side Diff: Source/core/events/OverflowEvent.cpp

Issue 959643002: Remove the overflowchanged event with a runtime flag (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: tests Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/dom/Document.cpp ('k') | Source/core/events/OverflowEvent.idl » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY 13 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY
14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR 16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR
17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, 17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR 19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY 20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 #include "config.h" 26 #include "config.h"
27 #include "core/events/OverflowEvent.h" 27 #include "core/events/OverflowEvent.h"
28 28
29 #include "platform/RuntimeEnabledFeatures.h"
30
29 namespace blink { 31 namespace blink {
30 32
31 OverflowEvent::OverflowEvent() 33 OverflowEvent::OverflowEvent()
32 : Event(EventTypeNames::overflowchanged, false, false) 34 : Event(EventTypeNames::overflowchanged, false, false)
33 , m_orient(VERTICAL) 35 , m_orient(VERTICAL)
34 , m_horizontalOverflow(false) 36 , m_horizontalOverflow(false)
35 , m_verticalOverflow(false) 37 , m_verticalOverflow(false)
36 { 38 {
39 ASSERT(RuntimeEnabledFeatures::overflowChangedEventEnabled());
37 } 40 }
38 41
39 OverflowEvent::OverflowEvent(bool horizontalOverflowChanged, bool horizontalOver flow, bool verticalOverflowChanged, bool verticalOverflow) 42 OverflowEvent::OverflowEvent(bool horizontalOverflowChanged, bool horizontalOver flow, bool verticalOverflowChanged, bool verticalOverflow)
40 : Event(EventTypeNames::overflowchanged, false, false) 43 : Event(EventTypeNames::overflowchanged, false, false)
41 , m_horizontalOverflow(horizontalOverflow) 44 , m_horizontalOverflow(horizontalOverflow)
42 , m_verticalOverflow(verticalOverflow) 45 , m_verticalOverflow(verticalOverflow)
43 { 46 {
47 ASSERT(RuntimeEnabledFeatures::overflowChangedEventEnabled());
44 ASSERT(horizontalOverflowChanged || verticalOverflowChanged); 48 ASSERT(horizontalOverflowChanged || verticalOverflowChanged);
45 49
46 if (horizontalOverflowChanged && verticalOverflowChanged) 50 if (horizontalOverflowChanged && verticalOverflowChanged)
47 m_orient = BOTH; 51 m_orient = BOTH;
48 else if (horizontalOverflowChanged) 52 else if (horizontalOverflowChanged)
49 m_orient = HORIZONTAL; 53 m_orient = HORIZONTAL;
50 else 54 else
51 m_orient = VERTICAL; 55 m_orient = VERTICAL;
52 } 56 }
53 57
54 OverflowEvent::OverflowEvent(const AtomicString& type, const OverflowEventInit& initializer) 58 OverflowEvent::OverflowEvent(const AtomicString& type, const OverflowEventInit& initializer)
55 : Event(type, initializer) 59 : Event(type, initializer)
56 , m_orient(0) 60 , m_orient(0)
57 , m_horizontalOverflow(false) 61 , m_horizontalOverflow(false)
58 , m_verticalOverflow(false) 62 , m_verticalOverflow(false)
59 { 63 {
64 ASSERT(RuntimeEnabledFeatures::overflowChangedEventEnabled());
65
60 if (initializer.hasOrient()) 66 if (initializer.hasOrient())
61 m_orient = initializer.orient(); 67 m_orient = initializer.orient();
62 if (initializer.hasHorizontalOverflow()) 68 if (initializer.hasHorizontalOverflow())
63 m_horizontalOverflow = initializer.horizontalOverflow(); 69 m_horizontalOverflow = initializer.horizontalOverflow();
64 if (initializer.hasVerticalOverflow()) 70 if (initializer.hasVerticalOverflow())
65 m_verticalOverflow = initializer.verticalOverflow(); 71 m_verticalOverflow = initializer.verticalOverflow();
66 } 72 }
67 73
68 const AtomicString& OverflowEvent::interfaceName() const 74 const AtomicString& OverflowEvent::interfaceName() const
69 { 75 {
70 return EventNames::OverflowEvent; 76 return EventNames::OverflowEvent;
71 } 77 }
72 78
73 DEFINE_TRACE(OverflowEvent) 79 DEFINE_TRACE(OverflowEvent)
74 { 80 {
75 Event::trace(visitor); 81 Event::trace(visitor);
76 } 82 }
77 83
78 } 84 }
OLDNEW
« no previous file with comments | « Source/core/dom/Document.cpp ('k') | Source/core/events/OverflowEvent.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698