Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 959423003: Telemetry: Add more details to inspector_backend exceptions. (Closed)

Created:
5 years, 9 months ago by erikchen
Modified:
5 years, 9 months ago
Reviewers:
nednguyen, dtu, sullivan
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@telemetry_make_new_exceptions4
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Telemetry: Add more details to inspector_backend exceptions. Previously, inspector_backend would always throw a DevtoolsTargetCrashException. Now, it throws either a DevtoolsTargetCrashException or a TimeoutException. The CL also adds the debugger_url to the exception as further debugging information. There were exactly 2 files that tried to catch a DevtoolsTargetCrashException. I changed fast_navigation_profile_extender to catch Error instead. I will be improving this class in the future to have better exception handling. chrome_proxy_measurements caught a DevtoolsTargetCrashException, but its behavior is better suited by catching a TimeoutException. BUG=460625 Committed: https://crrev.com/910d6e733bac30f15f76054eb101a81987f8c675 Cr-Commit-Position: refs/heads/master@{#319193}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Rebase against top of tree. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -11 lines) Patch
M tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/profile_creators/fast_navigation_profile_extender.py View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py View 1 2 1 chunk +42 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
erikchen
nednguyen: Please review.
5 years, 9 months ago (2015-02-28 00:26:39 UTC) #2
nednguyen
5 years, 9 months ago (2015-03-04 00:18:18 UTC) #4
sullivan
lgtm
5 years, 9 months ago (2015-03-04 14:56:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/959423003/20001
5 years, 9 months ago (2015-03-04 22:15:37 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/44692)
5 years, 9 months ago (2015-03-04 22:19:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/959423003/40001
5 years, 9 months ago (2015-03-05 00:14:23 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-05 02:08:01 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-03-05 02:09:00 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/910d6e733bac30f15f76054eb101a81987f8c675
Cr-Commit-Position: refs/heads/master@{#319193}

Powered by Google App Engine
This is Rietveld 408576698