tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py - Issue 959423003: Telemetry: Add more details to inspector_backend exceptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py

Issue 959423003: Telemetry: Add more details to inspector_backend exceptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@telemetry_make_new_exceptions4

Patch Set: Rebase against top of tree. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py

diff --git a/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py b/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py

index 0261b14c45b891224ad341a0fb191f17d6ef25f2..7fe40df1e22cd1f37fe6704a0e40f01664bbbde7 100644

--- a/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py

+++ b/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py

@@ -93,7 +93,7 @@ class ChromeProxyValidation(page_test.PageTest):

if self._expect_timeout:

raise metrics.ChromeProxyMetricException, (

'Timeout was expected, but did not occur')

- except exceptions.DevtoolsTargetCrashException, e:

+ except exceptions.TimeoutException as e:

if self._expect_timeout:

logging.warning('Navigation timeout on page %s',

page.name if page.name else page.url)

« no previous file with comments | « no previous file | tools/perf/profile_creators/fast_navigation_profile_extender.py » ('j') | no next file with comments »