tools/perf/profile_creators/fast_navigation_profile_extender.py - Issue 959423003: Telemetry: Add more details to inspector_backend exceptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/profile_creators/fast_navigation_profile_extender.py

Issue 959423003: Telemetry: Add more details to inspector_backend exceptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@telemetry_make_new_exceptions4

Patch Set: Rebase against top of tree. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py ('k') | tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/perf/profile_creators/fast_navigation_profile_extender.py

diff --git a/tools/perf/profile_creators/fast_navigation_profile_extender.py b/tools/perf/profile_creators/fast_navigation_profile_extender.py

index e4904038b9fcd63e22d1aa8c14d8bff752849954..abcc8ebbc945150d606b24699a472f14acd6c800 100644

--- a/tools/perf/profile_creators/fast_navigation_profile_extender.py

+++ b/tools/perf/profile_creators/fast_navigation_profile_extender.py

@@ -161,7 +161,7 @@ class FastNavigationProfileExtender(object):

"""Retrives the URL of the tab."""

try:

return tab.EvaluateJavaScript('document.URL', timeout)

- except (exceptions.DevtoolsTargetCrashException,

+ except (exceptions.Error,

devtools_http.DevToolsClientConnectionError,

devtools_http.DevToolsClientUrlError):

return None

@@ -204,7 +204,7 @@ class FastNavigationProfileExtender(object):

try:

tab.Navigate(url, None, timeout_in_seconds)

- except (exceptions.DevtoolsTargetCrashException,

+ except (exceptions.Error,

devtools_http.DevToolsClientConnectionError,

devtools_http.DevToolsClientUrlError):

# We expect a time out. It's possible for other problems to arise, but

@@ -242,7 +242,7 @@ class FastNavigationProfileExtender(object):

except exceptions.TimeoutException:

# Ignore time outs.

pass

- except (exceptions.DevtoolsTargetCrashException,

+ except (exceptions.Error,

devtools_http.DevToolsClientConnectionError,

devtools_http.DevToolsClientUrlError):

# If any error occurs, remove the tab. it's probably in an