Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 959403002: Initialize our quads to zero before we gl_->BufferData() with them. (Closed)

Created:
5 years, 9 months ago by awoloszyn
Modified:
5 years, 9 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews, ericrk
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize our quads to zero before we gl_->BufferData() with them. The data was never actually used, but msan was complaining. Fixed build BUG=

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -14 lines) Patch
M cc/output/dynamic_geometry_binding.cc View 1 2 chunks +8 lines, -8 lines 0 comments Download
M cc/output/geometry_binding.h View 1 1 chunk +13 lines, -0 lines 0 comments Download
M cc/output/geometry_binding.cc View 1 1 chunk +35 lines, -0 lines 4 comments Download
M cc/output/static_geometry_binding.cc View 1 1 chunk +6 lines, -6 lines 1 comment Download

Messages

Total messages: 13 (5 generated)
awoloszyn
5 years, 9 months ago (2015-02-27 21:26:32 UTC) #2
awoloszyn
5 years, 9 months ago (2015-02-27 21:35:43 UTC) #4
enne (OOO)
https://codereview.chromium.org/959403002/diff/1/cc/output/dynamic_geometry_binding.cc File cc/output/dynamic_geometry_binding.cc (right): https://codereview.chromium.org/959403002/diff/1/cc/output/dynamic_geometry_binding.cc#newcode15 cc/output/dynamic_geometry_binding.cc:15: GeometryBindingQuad quads[1]; Can you initialize this in the class ...
5 years, 9 months ago (2015-02-27 21:36:01 UTC) #6
awoloszyn
https://codereview.chromium.org/959403002/diff/1/cc/output/dynamic_geometry_binding.cc File cc/output/dynamic_geometry_binding.cc (right): https://codereview.chromium.org/959403002/diff/1/cc/output/dynamic_geometry_binding.cc#newcode15 cc/output/dynamic_geometry_binding.cc:15: GeometryBindingQuad quads[1]; On 2015/02/27 21:36:01, enne wrote: > Can ...
5 years, 9 months ago (2015-02-27 22:08:37 UTC) #7
danakj
https://codereview.chromium.org/959403002/diff/20001/cc/output/geometry_binding.cc File cc/output/geometry_binding.cc (right): https://codereview.chromium.org/959403002/diff/20001/cc/output/geometry_binding.cc#newcode46 cc/output/geometry_binding.cc:46: memset(&v0, 0x0, sizeof(GeometryBindingVertex)); (0x0 is a very verbose way ...
5 years, 9 months ago (2015-02-27 22:10:54 UTC) #9
enne (OOO)
https://codereview.chromium.org/959403002/diff/20001/cc/output/geometry_binding.cc File cc/output/geometry_binding.cc (right): https://codereview.chromium.org/959403002/diff/20001/cc/output/geometry_binding.cc#newcode46 cc/output/geometry_binding.cc:46: memset(&v0, 0x0, sizeof(GeometryBindingVertex)); Please no memset. Just initialize these ...
5 years, 9 months ago (2015-02-27 22:12:07 UTC) #11
awoloszyn
https://codereview.chromium.org/959403002/diff/20001/cc/output/geometry_binding.cc File cc/output/geometry_binding.cc (right): https://codereview.chromium.org/959403002/diff/20001/cc/output/geometry_binding.cc#newcode46 cc/output/geometry_binding.cc:46: memset(&v0, 0x0, sizeof(GeometryBindingVertex)); On 2015/02/27 22:10:54, danakj wrote: > ...
5 years, 9 months ago (2015-02-27 22:13:54 UTC) #12
enne (OOO)
5 years, 9 months ago (2015-03-09 17:52:04 UTC) #13
I'll close this patch then, if these changes are getting rolled into a different
patch.

Powered by Google App Engine
This is Rietveld 408576698