cc/output/static_geometry_binding.cc - Issue 959403002: Initialize our quads to zero before we gl_->BufferData() with them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/output/static_geometry_binding.cc

Issue 959403002: Initialize our quads to zero before we gl_->BufferData() with them. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/output/static_geometry_binding.cc

diff --git a/cc/output/static_geometry_binding.cc b/cc/output/static_geometry_binding.cc

index 2a41fafdbf66dc36a668714eee56b1309282df21..fa0c6cb27e9cdb5aac64ce94ff8f7c2574a5118f 100644

--- a/cc/output/static_geometry_binding.cc

+++ b/cc/output/static_geometry_binding.cc

@@ -40,12 +40,12 @@ StaticGeometryBinding::StaticGeometryBinding(gpu::gles2::GLES2Interface* gl,

i * 4.0f + 3.0f};

GeometryBindingQuad x = {v0, v1, v2, v3};

quads[i] = x;

- GeometryBindingQuadIndex y = {{static_cast<uint16>(0 + 4 * i),

- static_cast<uint16>(1 + 4 * i),

- static_cast<uint16>(2 + 4 * i),

- static_cast<uint16>(3 + 4 * i),

- static_cast<uint16>(0 + 4 * i),

- static_cast<uint16>(2 + 4 * i)}};

+ GeometryBindingQuadIndex y = {static_cast<uint16>(0 + 4 * i),

enne (OOO) 2015/02/27 22:12:07 Use direct or copy initialization, not list initia

+ static_cast<uint16>(1 + 4 * i),

+ static_cast<uint16>(2 + 4 * i),

+ static_cast<uint16>(3 + 4 * i),

+ static_cast<uint16>(0 + 4 * i),

+ static_cast<uint16>(2 + 4 * i)};

quad_indices[i] = y;

}

« cc/output/geometry_binding.cc ('K') | « cc/output/geometry_binding.cc ('k') | no next file » | no next file with comments »