Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: cc/output/geometry_binding.cc

Issue 959403002: Initialize our quads to zero before we gl_->BufferData() with them. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/output/geometry_binding.cc
diff --git a/cc/output/geometry_binding.cc b/cc/output/geometry_binding.cc
index c3cdf7319c4e2549c7aed39c40fbc0ce1d899377..3473cc9c64d421b9299ded5a4a89a05f7f7a95d5 100644
--- a/cc/output/geometry_binding.cc
+++ b/cc/output/geometry_binding.cc
@@ -42,4 +42,39 @@ void SetupGLContext(gpu::gles2::GLES2Interface* gl,
GeometryBinding::TriangleIndexAttribLocation()));
}
+GeometryBindingQuad::GeometryBindingQuad() {
+ memset(&v0, 0x0, sizeof(GeometryBindingVertex));
danakj 2015/02/27 22:10:54 (0x0 is a very verbose way of just saying 0)
enne (OOO) 2015/02/27 22:12:07 Please no memset. Just initialize these directly.
awoloszyn 2015/02/27 22:13:54 Will do. My other patch is getting reverted for ot
awoloszyn 2015/02/27 22:13:54 Its an old habbit will fix. On that note, the CL t
+ memset(&v1, 0x0, sizeof(GeometryBindingVertex));
+ memset(&v2, 0x0, sizeof(GeometryBindingVertex));
+ memset(&v3, 0x0, sizeof(GeometryBindingVertex));
+}
+
+GeometryBindingQuad::GeometryBindingQuad(const GeometryBindingVertex& vert0,
+ const GeometryBindingVertex& vert1,
+ const GeometryBindingVertex& vert2,
+ const GeometryBindingVertex& vert3) {
+ v0 = vert0;
+ v1 = vert1;
+ v2 = vert2;
+ v3 = vert3;
+}
+
+GeometryBindingQuadIndex::GeometryBindingQuadIndex() {
+ memset(data, 0x0, sizeof(data));
+}
+
+GeometryBindingQuadIndex::GeometryBindingQuadIndex(uint16 index0,
+ uint16 index1,
+ uint16 index2,
+ uint16 index3,
+ uint16 index4,
+ uint16 index5) {
+ data[0] = index0;
+ data[1] = index1;
+ data[2] = index2;
+ data[3] = index3;
+ data[4] = index4;
+ data[5] = index5;
+}
+
} // namespace cc

Powered by Google App Engine
This is Rietveld 408576698