Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(963)

Issue 958933002: Revert of [Android WebView] Synthesize a fake page loading event on page source modification (Closed)

Created:
5 years, 9 months ago by grt (UTC plus 2)
Modified:
5 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android WebView] Synthesize a fake page loading event on page source modification (patchset #8 id:140001 of https://codereview.chromium.org/924833003/) Reason for revert: Reverting to see if this caused AwContentsClientFullScreenTest#testPowerSaveBlockerIsTransferredToFullscreen failure here: http://crbug.com/462213. Original issue's description: > [Android WebView] Synthesize a fake page loading event on page source modification > > When a script modifies page source of a non-committed page, we need to > notify clients, so they can update the URL bar to avoid confusion. > > BUG=458569 > > Committed: https://crrev.com/e38bb6cdeb1170cb2cd7faae8507dc6c34c58c7d > Cr-Commit-Position: refs/heads/master@{#318222} TBR=torne@chromium.org,tedchoc@chromium.org,davidben@chromium.org,creis@chromium.org,mnaganov@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=458569 Committed: https://crrev.com/c2d96fa87b653355fc8335c0accecff8852cae5d Cr-Commit-Position: refs/heads/master@{#318231}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -200 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwContents.java View 2 chunks +0 lines, -18 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegate.java View 1 chunk +0 lines, -4 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java View 3 chunks +0 lines, -16 lines 0 comments Download
M android_webview/java_library_common.mk View 1 chunk +0 lines, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/PopupWindowTest.java View 7 chunks +23 lines, -51 lines 0 comments Download
M android_webview/libwebviewchromium.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M android_webview/native/aw_web_contents_delegate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M android_webview/native/aw_web_contents_delegate.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/Tab.java View 2 chunks +2 lines, -3 lines 0 comments Download
M components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java View 2 chunks +10 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_android.h View 2 chunks +0 lines, -4 lines 0 comments Download
M content/browser/web_contents/web_contents_android.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M content/content.gyp View 2 chunks +0 lines, -9 lines 0 comments Download
M content/public/android/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java View 4 chunks +0 lines, -13 lines 0 comments Download
M content/public/android/java/src/org/chromium/content_public/browser/WebContents.java View 2 chunks +0 lines, -16 lines 0 comments Download
M content/public/browser/invalidate_type.h View 1 chunk +0 lines, -5 lines 0 comments Download
M net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java View 5 chunks +2 lines, -25 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
grt (UTC plus 2)
Created Revert of [Android WebView] Synthesize a fake page loading event on page source modification
5 years, 9 months ago (2015-02-26 14:25:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/958933002/1
5 years, 9 months ago (2015-02-26 14:26:25 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-02-26 14:27:01 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-02-26 14:28:01 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c2d96fa87b653355fc8335c0accecff8852cae5d
Cr-Commit-Position: refs/heads/master@{#318231}

Powered by Google App Engine
This is Rietveld 408576698