android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java - Issue 958933002: Revert of [Android WebView] Synthesize a fake page loading event on page source modification

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java

Issue 958933002: Revert of [Android WebView] Synthesize a fake page loading event on page source modification (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegate.java ('k') | android_webview/java_library_common.mk » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java b/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java

index 10ae2a54fed07640fb8502ebf49be20922d7e56e..3f2c707dce8447bc8b0abc5a24dc508ac6b8c1b2 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java

@@ -11,7 +11,6 @@

import android.os.Handler;

import android.os.Message;

import android.provider.MediaStore;

-import android.text.TextUtils;

import android.util.Log;

import android.view.KeyEvent;

import android.view.View;

@@ -20,7 +19,6 @@

import org.chromium.base.ContentUriUtils;

import org.chromium.base.ThreadUtils;

-import org.chromium.content_public.browser.InvalidateTypes;

/**

* Adapts the AwWebContentsDelegate interface to the AwContentsClient interface.

@@ -215,20 +213,6 @@

}

@Override

- public void navigationStateChanged(int flags) {

- if ((flags & InvalidateTypes.URL) != 0 && mAwContents.hasAccessedInitialDocument()) {

- // Hint the client to show the last committed url, as it may be unsafe to show

- // the pending entry.

- String url = mAwContents.getLastCommittedUrl();

- url = TextUtils.isEmpty(url) ? "about:blank" : url;

- mContentsClient.onPageStarted(url);

- mContentsClient.onLoadResource(url);

- mContentsClient.onProgressChanged(100);

- mContentsClient.onPageFinished(url);

- }

- @Override

public void toggleFullscreenModeForTab(boolean enterFullscreen) {

if (enterFullscreen) {

mContentViewClient.enterFullscreen();