components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java - Issue 958933002: Revert of [Android WebView] Synthesize a fake page loading event on page source modification

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java

Issue 958933002: Revert of [Android WebView] Synthesize a fake page loading event on page source modification (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/Tab.java ('k') | content/browser/web_contents/web_contents_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java

diff --git a/components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java b/components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java

index 6b1026eb383ef86d2c7adf34ba8280863776f0a3..d04e16a6ee07ffdba4be53e8d931c637cdc434cd 100644

--- a/components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java

+++ b/components/web_contents_delegate_android/android/java/src/org/chromium/components/web_contents_delegate_android/WebContentsDelegateAndroid.java

@@ -8,7 +8,6 @@

import org.chromium.base.CalledByNative;

import org.chromium.base.JNINamespace;

-import org.chromium.content_public.browser.InvalidateTypes;

import org.chromium.content_public.browser.WebContents;

/**

@@ -26,8 +25,16 @@

// Equivalent of WebCore::WebConsoleMessage::LevelError.

public static final int LOG_LEVEL_ERROR = 3;

- // TODO(mnaganov): Remove after getting rid of downstream usages.

- public static final int INVALIDATE_TYPE_TAB = InvalidateTypes.TAB;

+ // Flags passed to the WebContentsDelegateAndroid.navigationStateChanged to tell it

+ // what has changed. Should match the values in invalidate_type.h.

+ // Equivalent of InvalidateTypes::INVALIDATE_TYPE_URL.

+ public static final int INVALIDATE_TYPE_URL = 1 << 0;

+ // Equivalent of InvalidateTypes::INVALIDATE_TYPE_TAB.

+ public static final int INVALIDATE_TYPE_TAB = 1 << 1;

+ // Equivalent of InvalidateTypes::INVALIDATE_TYPE_LOAD.

+ public static final int INVALIDATE_TYPE_LOAD = 1 << 2;

+ // Equivalent of InvalidateTypes::INVALIDATE_TYPE_TITLE.

+ public static final int INVALIDATE_TYPE_TITLE = 1 << 3;

// The most recent load progress callback received from WebContents, as a percentage.

// Initialize to 100 to indicate that we're not in a loading state.