Issue 958923004: Fix hiding behavior when creating app windows.

Issue 958923004: Fix hiding behavior when creating app windows. (Closed)

Created:
5 years, 10 months ago by jackhou1

Modified:
5 years, 9 months ago

Reviewers:
benwells

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Fix hiding behavior when creating app windows. This ensures that re-creating a window with the same id shows that window if it already exists. This was broken in: https://codereview.chromium.org/417433002 BUG=461081 Committed: https://crrev.com/0e3bba803a97b1a649fd9359c19fc0356e2da684 Cr-Commit-Position: refs/heads/master@{#319013}

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -1 line)			Patch
M	chrome/browser/apps/app_window_interactive_uitest.cc	View	1 2	1 chunk	+36 lines, -0 lines	0 comments	Download
A +	chrome/test/data/extensions/platform_apps/hidden_with_id/empty.html	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/test/data/extensions/platform_apps/hidden_with_id/manifest.json	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
A	chrome/test/data/extensions/platform_apps/hidden_with_id/test.js	View	1 2	1 chunk	+31 lines, -0 lines	0 comments	Download
M	extensions/browser/api/app_window/app_window_api.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/958923004/60001

5 years, 9 months ago (2015-03-04 02:13:21 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-04 03:18:51 UTC) #7

Message was sent while issue was closed.

Patchset 4 (id:??) landed as
https://crrev.com/0e3bba803a97b1a649fd9359c19fc0356e2da684
Cr-Commit-Position: refs/heads/master@{#319013}