extensions/browser/api/app_window/app_window_api.cc - Issue 958923004: Fix hiding behavior when creating app windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/app_window/app_window_api.cc

Issue 958923004: Fix hiding behavior when creating app windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove changes to platform_apps/hidden/test.js Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/app_window/app_window_api.cc

diff --git a/extensions/browser/api/app_window/app_window_api.cc b/extensions/browser/api/app_window/app_window_api.cc

index f8cd74a57a2516710ec8c7a92c71cab6f2e2e51d..3f5123ff9d5491fb97dc09199485deeeca98a103 100644

--- a/extensions/browser/api/app_window/app_window_api.cc

+++ b/extensions/browser/api/app_window/app_window_api.cc

@@ -182,7 +182,7 @@ bool AppWindowCreateFunction::RunAsync() {

view_id = created_view->GetRoutingID();

}

- if (options->hidden.get() && !*options->hidden.get()) {

+ if (!options->hidden.get() || !*options->hidden.get()) {

if (options->focused.get() && !*options->focused.get())

window->Show(AppWindow::SHOW_INACTIVE);

else

« no previous file with comments | « chrome/test/data/extensions/platform_apps/hidden_with_id/test.js ('k') | no next file » | no next file with comments »