Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 417433002: app.window.create() only shows the window if !createOptions.hidden. (Closed)

Created:
6 years, 5 months ago by jackhou1
Modified:
6 years, 5 months ago
Reviewers:
benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

app.window.create() only shows the window if !createOptions.hidden. BUG=391812 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285194

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M chrome/browser/extensions/api/app_window/app_window_api.cc View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jackhou1
The logic here is that if I call create() a second time with hidden == ...
6 years, 5 months ago (2014-07-23 04:02:48 UTC) #1
benwells
lgtm
6 years, 5 months ago (2014-07-23 10:20:41 UTC) #2
jackhou1
The CQ bit was checked by jackhou@chromium.org
6 years, 5 months ago (2014-07-23 22:14:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jackhou@chromium.org/417433002/1
6 years, 5 months ago (2014-07-23 22:16:49 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 11:42:12 UTC) #5
Message was sent while issue was closed.
Change committed as 285194

Powered by Google App Engine
This is Rietveld 408576698