Fix comparison of forward-declared and fully visible types

Fix comparison of forward-declared and fully visible types

Patch in 65ee89744bc1fbb9461f26d83e08243068cb212b that fixes comparison
between opaque and non-opaque type (i.e. whether or not the contents of
the structure is known at the point of compilation).

https://github.com/carllindberg/ocmock/commit/65ee89744bc1fbb9461f26d83e08243068cb212b

BUG=459013
Committed: https://crrev.com/85b90ad128c95c9328f1ef883818908f910b7fd5
Cr-Commit-Position: refs/heads/master@{#318059}

[sdefresne, 2015-02-25 13:58:42]

sdefresne@chromium.org changed reviewers:
+ thakis@chromium.org

[sdefresne, 2015-02-25 13:58:42]

This CL has been uploaded in two part, the first part reverts
https://codereview.chromium.org/316873003 (which was my original implementation)
and the second part port the upstream patch found at
https://github.com/carllindberg/ocmock/commit/65ee89744bc1fbb9461f26d83e08243...
(+pull in the implementation of OCMTypeWithoutQualifiers).

Please take a look.

[Nico, 2015-02-25 15:46:05]

rs-lgtm

should we just roll to a newer ocmock altogether?

[sdefresne, 2015-02-25 15:58:07]

On 2015/02/25 15:46:05, Nico wrote:
> rs-lgtm
> 
> should we just roll to a newer ocmock altogether?

There is a comment in third_party/ocmock/README.chromium saying that we cannot
roll ocmock past b5773084d56d2573caf6a2d98d5b56e301673de1 as it depends on 10.7.
I have not investigated whether this is the case or not, but IIRC, Chromium on
mac targets 10.6.

[sdefresne, 2015-02-25 15:58:10]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2015-02-25 15:59:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/958613003/20001

[commit-bot: I haz the power, 2015-02-25 16:32:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-25 16:32:55]

Patchset 2 (id:??) landed as
https://crrev.com/85b90ad128c95c9328f1ef883818908f910b7fd5
Cr-Commit-Position: refs/heads/master@{#318059}